After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674777 - What's the (transfer) of g_variant_lookup()?
What's the (transfer) of g_variant_lookup()?
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gvariant
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-04-25 09:31 UTC by Guillaume Desmottes
Modified: 2012-05-28 08:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Link to gvariant-format-strings-pointers in getter API (2.98 KB, patch)
2012-04-27 08:04 UTC, Guillaume Desmottes 		none Details | Review
Link to gvariant-format-strings-pointers in getter API (3.43 KB, patch)
2012-05-01 06:49 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-04-25 09:31:12 UTC 
We just don't know, the code should say clearly if the values extracted using g_variant_lookup() are owned by the caller or not.
Comment 1 Guillaume Desmottes 2012-04-27 08:04:12 UTC 
Created attachment 212931 [details] [review]
Link to gvariant-format-strings-pointers in getter API
Comment 2 Allison Karlitskaya (desrt) 2012-04-27 13:06:08 UTC 
Review of attachment 212931 [details] [review]:

I'd change the wording a bit to not just include "copied or borrowed" but also mention that the format string affects the type of arguments.

Maybe something like "The format string determines the C types that are used for unpacking the values and also determines if..."
Comment 3 Guillaume Desmottes 2012-05-01 06:49:09 UTC 
Created attachment 213165 [details] [review]
Link to gvariant-format-strings-pointers in getter API
Comment 4 Allison Karlitskaya (desrt) 2012-05-26 14:21:44 UTC 
Review of attachment 213165 [details] [review]:

Sorry this slipped between the cracks for a while.  Looks good in its current form.  Thanks.
Comment 5 Guillaume Desmottes 2012-05-28 08:55:19 UTC 
Attachment 213165 [details] pushed as ae421c9 - Link to gvariant-format-strings-pointers in getter API