After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674738 - org.gnome.UPnP.MediaObject2.Type: values for music defined by spec and rygel do not match
org.gnome.UPnP.MediaObject2.Type: values for music defined by spec and rygel ...
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: External plugin
unspecified
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-24 17:29 UTC by Alexander Kanavin
Modified: 2012-10-12 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
external: Use audio.music as specified in spec (1.80 KB, patch)
2012-04-27 18:37 UTC, Jens Georg
committed Details | Review

Description Alexander Kanavin 2012-04-24 17:29:28 UTC
Should music files have Type property set to 'audio.music' or 'music'?

The spec for the type property says:

"'Type' tells what kind of object we are dealing with and it's value must be 'container' in case of container or either of 'video', 'video.movie', 'audio', 'audio.music', 'image' or 'image.photo' in case of item."

While the rygel code is:

        if (type.has_prefix ("audio")) {
            item = new AudioItem (id, parent, title);

            this.set_audio_metadata (item as AudioItem, props, service_name);
        } else if (type.has_prefix ("music")) {
            item = new MusicItem (id, parent, title);

            yield this.set_music_metadata (item as MusicItem,
                                           props,
                                           service_name);
...

It's probably easier to fix the spec.
Comment 1 Jens Georg 2012-04-26 17:59:59 UTC
Dread. The correct way would be "audio.music" but apparently people just worked around it instead of filing a bug.
Comment 2 Jens Georg 2012-04-27 18:37:58 UTC
Created attachment 212990 [details] [review]
external: Use audio.music as specified in spec

We still keep "music" as everyone else seems to be using it now.

I fixed the spec to mention music though.
Comment 3 Jens Georg 2012-10-12 09:39:58 UTC
Attachment 212990 [details] pushed as a973c53 - external: Use audio.music as specified in spec