After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674731 - Don't allow shape mask texture to be sliced
Don't allow shape mask texture to be sliced
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-24 16:08 UTC by Robert Bragg
Modified: 2012-04-25 11:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
shaped-texture: never slice shape mask texture (2.12 KB, patch)
2012-04-24 16:08 UTC, Robert Bragg
committed Details | Review

Description Robert Bragg 2012-04-24 16:08:11 UTC
Created attachment 212715 [details] [review]
shaped-texture: never slice shape mask texture

Since Cogl doesn't support multi-texturing with sliced textures and the shape texture is combined with the texture-from-pixmap texture we need to make sure we never construct a sliced mask texture otherwise on some platforms without full npot texture support we can be left with blank white windows when Cogl detects the sliced texture and replaces the tfp texture with a default white texture.
Comment 1 Owen Taylor 2012-04-24 18:09:23 UTC
Review of attachment 212715 [details] [review]:

Looks good
Comment 2 Robert Bragg 2012-04-25 11:02:29 UTC
Thanks, I've pushed the patch to master as commit a22859a64a60