Created attachment 212710 [details] [review]
Fix compilation warning

This patch fix the first warning

Created attachment 212729 [details] [review]
Make support for "XFree86" Xinerama mandatory

Require the headers for "XFree86" Xinerama to be present at compile
time. The older "Solaris" Xinerama is only needed for versions of
Solaris where Mutter is unlikely to work. Solaris 10 and 11 include
the XFree86 Xinerama libraries, and apparently that's the only version
that will actually work for Solaris 11, which uses Xorg.

Review of attachment 212729 [details] [review]:

Looks good, lest some nitpicks regarding debug messages:

::: src/core/screen.c
@@ +555,1 @@
                   "No XFree86 Xinerama extension or XFree86 Xinerama inactive on display %s\n",

Only the latter is still possible, right?

@@ +558,2 @@
   meta_topic (META_DEBUG_XINERAMA,
               "Mutter compiled without XFree86 Xinerama support\n");

Wrong :-)

Review of attachment 212729 [details] [review]:

It's worth noting that "git annotate" traces the code you're deleting to:

commit 74b3bca93d0223e3b273c7613b9020fdbd8fef80
Author: Havoc Pennington <hp@redhat.com>
Date:   Fri Sep 27 20:28:34 2002 +0000

    Try to handle Solaris Xinerama, all coded blind, someone on Solaris will need to debug the typos.

Sooo...yeah =)  Patch looks correct to me.

Comment on attachment 212729 [details] [review]
Make support for "XFree86" Xinerama mandatory

Oops, I overwrite Florian's review status accidentally.  His "reviewed" state should stand.

(In reply to comment #3)
> Review of attachment 212729 [details] [review]:
> 
> Looks good, lest some nitpicks regarding debug messages:
> 
> ::: src/core/screen.c
> @@ +555,1 @@
>                    "No XFree86 Xinerama extension or XFree86 Xinerama inactive
> on display %s\n",
> 
> Only the latter is still possible, right?

I don't think so - there's a distinction between the extension not being present at all, and being in the inactive state.

Bool XineramaIsActive(Display *dpy)
{
    xXineramaIsActiveReply      rep;
    xXineramaIsActiveReq        *req;
    XExtDisplayInfo             *info = find_display (dpy);

    if(!XextHasExtension(info))
        return False;  /* server doesn't even have the extension */

    LockDisplay (dpy);
    GetReq (XineramaIsActive, req);
    req->reqType = info->codes->major_opcode;
    req->panoramiXReqType = X_XineramaIsActive;
    if (!_XReply (dpy, (xReply *) &rep, 0, xTrue)) {
        UnlockDisplay (dpy);
        SyncHandle ();
        return False;
    }
    UnlockDisplay (dpy);
    SyncHandle ();
    return rep.state;
}

I've changed the message to remove "XFree86" but otherwise left it unchanged. (And removed the other leftover, thanks)

Attachment 212729 [details] pushed as 93037e4 - Make support for "XFree86" Xinerama mandatory