GNOME Bugzilla – Bug 674722
[hlsdemux] Some bugfixes
Last modified: 2012-10-06 11:54:02 UTC
http://cgit.collabora.com/git/user/kakaroto/gst-plugins-bad.git/log/ These unfortunately do not apply anymore after the refactoring done recently but at least some of them look still valid.
The refactoring is the one described in bug #657790
I've reset the master, the patches are now in their own branch : http://cgit.collabora.com/git/user/kakaroto/gst-plugins-bad.git/log/?h=hlsdemux
I pushed a branch cherry-picking the commits that were still relevant here: http://cgit.collabora.com/git/user/tsaunier/gst-plugins-bad/log/?h=hlsfix If someone wants to have a look, it would be great, else I guess I will just push it so it doesn't get lost once more.
Looks good to me :) 1b98dca926c10e6ae1d2317af11e8a3380a546be has some wrong stuff at the end of the commit message 5d702038ace9155ed3bfe78d082b76e015b6a0a7 in this context it might make sense to add a connection-speed property to hlsdemux, similar to the network source (e.g. mmssrc) and proxy this from uridecodebin to decodebin2 to the elements.
I added the connection-speed property into hlsdemux at: http://cgit.collabora.com/git/user/tsaunier/gst-plugins-bad/log/?h=hlsfix And I pushed a fix in decodebin2/uridecodebin to handle that properly: http://cgit.collabora.com/git/user/tsaunier/gst-plugins-base/commit/?id=81730a78e91200adbeaffedb543ddd37695e6d9d
(In reply to comment #5) > I added the connection-speed property into hlsdemux at: > http://cgit.collabora.com/git/user/tsaunier/gst-plugins-bad/log/?h=hlsfix > > And I pushed a fix in decodebin2/uridecodebin to handle that properly: > http://cgit.collabora.com/git/user/tsaunier/gst-plugins-base/commit/?id=81730a78e91200adbeaffedb543ddd37695e6d9d Looks good but please also check the property type (if it's int or uint). I think we have a helper function for that somewhere. Why all the * 1000 and / 1000 btw?
And when pushing that to fd.o, please also merge into master :)
commit c503b352e7a525eba3f746e69781492f49dedb4f Author: Thibault Saunier <thibault.saunier@collabora.com> Date: Thu May 10 10:11:18 2012 -0400 hlsdemux: Add a connection-speed property .... to: commit 758585122338f42089bf28178bb2ce8ce1aad370 Author: Youness Alaoui <youness.alaoui@collabora.co.uk> Date: Thu Sep 15 20:47:54 2011 -0400 hlsdemux: Fallback to previous playlist when switching if the new playlist can't be fetched