After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674576 - [PATCH] [OSX] Use gtk-mac-integration over ige-mac-integration
[PATCH] [OSX] Use gtk-mac-integration over ige-mac-integration
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Mac OS
: Normal enhancement
: ---
Assigned To: Timo Dörr
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-22 17:27 UTC by David Nielsen
Modified: 2012-06-04 19:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description David Nielsen 2012-04-22 17:27:18 UTC 
ige-mac-integration is now renamed to gtk-mac-integration. We should upgrade to the newer version for bugfixes and superior integration. 

https://live.gnome.org/GTK%2B/OSX/Integration
Comment 1 David Nielsen 2012-05-07 17:27:54 UTC 
Timo earns a CC since he is my OS X minion for the summer
Comment 2 David Nielsen 2012-05-22 20:09:38 UTC 
Timo already ported Banshee and has a patch in his bockbuild instance. 

https://raw.github.com/Dynalon/bockbuild/62756ec7493793aed3f00f010fea7da6e07d1a83/packages/patches/banshee-gtk-mac-integration.patch
Comment 3 Timo Dörr 2012-05-22 20:32:45 UTC 
yes there is basic support for it, but its not perfect yet. Its a mere copy/paste to replace ige_mac_* with gtk_mac_* counterparts. The gtk_mac_* API uses the deprecated carbon, I will want to look first to see if i can implemente using GtkOSXApplication interface, which would use Cocoa. Additionally, the Mac OS X key modifiers do not work yet.

I'll send a complete patch when its more complete, hopefully by end of the week.
Comment 4 Timo Dörr 2012-06-02 18:19:05 UTC 
ok the patch should go upstream into master. If I integrate the Cocoa-based integration it'll go into another backend so it can co-exist with the Carbon implementation.
Comment 5 Bertrand Lorentz 2012-06-04 19:46:13 UTC 
Grr, my previous comment was lost in the database hardware failure.
I hope you got my remarks by e-mail.

So, anyway, patch committed with a few changes:
http://git.gnome.org/browse/banshee/commit/?id=d71b10311