After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674551 - printers: Move expensive initialization to an idle
printers: Move expensive initialization to an idle
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: printers
unspecified
Other All
: Normal normal
: ---
Assigned To: Marek Kašík
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-22 01:22 UTC by Matthias Clasen
Modified: 2012-04-23 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
printers: Move expensive initialization to an idle (2.43 KB, patch)
2012-04-22 01:22 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2012-04-22 01:22:40 UTC 
The start() function is running before gsd finishes its
session registration, so everything we do here is in the
critical path for session startup. Both cupsGetDests and
the subscription registration are potentially expensive,
and can very well be done later.
Comment 1 Matthias Clasen 2012-04-22 01:22:42 UTC 
Created attachment 212529 [details] [review]
printers: Move expensive initialization to an idle
Comment 2 Marek Kašík 2012-04-23 15:43:59 UTC 
Hi,

thank you for the patch. I've committed a little modified version of it. I left some initializations in gsd_print_notifications_manager_start() for the possibility of calling of gsd_print_notifications_manager_stop() sooner than gsd_print_notifications_manager_start_idle().

Regards

Marek