After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674537 - GtkMenuPositionFunc: x and y should be "inout"
GtkMenuPositionFunc: x and y should be "inout"
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkMenu
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-04-21 18:32 UTC by Torsten Schoenfeld
Modified: 2015-01-17 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk_status_icon_position_menu patch (1.10 KB, patch)
2014-12-10 08:40 UTC, Christoph Reiter (lazka) 		committed Details | Review

Description Torsten Schoenfeld 2012-04-21 18:32:19 UTC 
The x and y parameters of GtkMenuPositionFunc are currently labeled as "out".  But the code in gtk_menu_position actually populates them with useful values before calling the GtkMenuPositionFunc, so I think x and y should be labeled "inout".  Note that this would constitute an API change for introspection-based bindings.  And if this change were to be made, the annotations for gtk_status_icon_position_menu would need to be changed similarly.
Comment 2 Matthias Clasen 2014-12-09 03:43:04 UTC 
not sure if changing this now would be an introspection api break ?
Comment 3 Emmanuele Bassi (:ebassi) 2014-12-09 11:11:51 UTC 
it would be for some languages, but admittedly that's how the API is supposed to be used.

it would probably need to be part of the release notes.
Comment 4 Christoph Reiter (lazka) 2014-12-10 08:40:15 UTC 
Created attachment 292422 [details] [review]
gtk_status_icon_position_menu patch

Please also change gtk_status_icon_position_menu as mentioned above.
Comment 5 Emmanuele Bassi (:ebassi) 2014-12-10 14:23:03 UTC 
Review of attachment 292422 [details] [review]:

ACK.