Created attachment 215243 [details] [review]
network: fix packing order of children in the service dialog

The heading should be packed at the top, before the combobox.

Comment on attachment 215243 [details] [review]
network: fix packing order of children in the service dialog

Attachment 215243 [details] pushed as cde88dc - network: fix packing order of children in the service dialog

Keeping the bug open, since the whole dialog is in need of a makeover.

If the only type of interface you are able to add is VPN, we might as well skip this dialog and go straight to the select VPN type dialog.

Does anyone know if there are plans to be able to add other interface types?

See bug 645097 which is about creating new mobile broadband connections.

This is covered in https://github.com/gnome-design-team/gnome-mockups/raw/master/system-settings/network/aday/png/vpn.png

So, whats missing here is just turning the combobox in the add connection dialog into a dsl/mobile/vpn list.

Created attachment 226708 [details] [review]
patch

Preliminary patch. Still missing: detect dsl and mobile, update the ui, and handle creating these kinds of connection.

Also, somewhat related to this issue.
When there is no VPN plugins available, you can still get the VPN option in
the dropdown, and clicking "Create..." results in nothing happening.
Investigating this a bit, the code spawns nm-connection-editor like this:

nm-connection-editor --create --type vpn

which results in (when running this command from a shell):

** (nm-connection-editor:3523): WARNING **: vpn_ask_connection_type: no VPN plugins could be found!

thus there is no UI feedback.

Maybe nm-connection-editor needs to handle this better, or some VPN plugin needs to be a "lest-common-denominator" depency (for distros, in this case Debian).

(In reply to comment #6)
> So, whats missing here is just turning the combobox in the add connection
> dialog into a dsl/mobile/vpn list.

Though not currently possible, it would be easy to make it so that you can launch the nm-connection-editor dialog showing only a subset of types. That way you wouldn't have to first select VPN, and then separately select the type of VPN.

The menu would look something like:

Hardware
  Mobile broadband
Virtual
  Bond
  Bridge
  VLAN
VPN
  Cisco blah blah
  OpenVPN
  etcVPN

or we could drop the headers for this case, especially if there's only going to be one "Hardware" type

This exists on wip/networking2 now... not really worth attaching the patch here since it depends on all the rest of that branch anyway.

Notes:

  - The "Add Connection" dialog becomes the connection editor window
    once you select a type (as opposed to closing and having a new
    window open). The mockups weren't explicit about this, but I figured
    that since both windows were the same size, that that was the intent.

  - The mockup says "Virtual Network", but I kept it as "VLAN",
    because that's what people who use VLANs call them, and "Virtual
    Network" sounds like it could mean various other things too
    (like a network device for a VM).

  - There's no equivalent to nm-c-e's "If the type of VPN connection
    you wish to create does not appear in the list, you may not have
    the correct VPN plugin installed" message.

  - Currently, if you try to create a Bridge, Bond, or VLAN connection,
    it just launches nm-c-e.

Created attachment 234250 [details] [review]
network: fall back to nm-connection-editor for unknown types

If asked to create or edit an unrecognized type, hand it off to
nm-connection-editor.

Created attachment 234251 [details] [review]
network: add integrated "Add New Connection"

New VPN connections are created within the control center; other types
currently hit the nm-connection-editor fallback.

Review of attachment 226708 [details] [review]:

Fine.

Review of attachment 234250 [details] [review]:

Looks good.

Review of attachment 234251 [details] [review]:

::: panels/network/connection-editor/net-connection-editor.c
@@ +761,3 @@
+                              "service", &service_name,
+                              NULL);
+                // FIXME: can't hardcode fgcolor

Did you mean to use <class name="dim-label"> here?

(In reply to comment #15)
> Did you mean to use <class name="dim-label"> here?

huh. I somehow attached an old version of the patch. Interdiff:

diff --git b/panels/network/connection-editor/net-connection-editor.c a/panels/network/connection-editor/net-connection-editor.c
index 16d6bbd..106cdae 100644
--- b/panels/network/connection-editor/net-connection-editor.c
+++ a/panels/network/connection-editor/net-connection-editor.c
@@ -756,2 +756,3 @@ select_vpn_type (NetConnectionEditor *editor, EggListBox *list)
                 char *name, *desc, *desc_markup, *service_name;
+                GtkStyleContext *context;
 
@@ -762,4 +763,3 @@ select_vpn_type (NetConnectionEditor *editor, EggListBox *list)
                               NULL);
-                // FIXME: can't hardcode fgcolor
-                desc_markup = g_markup_printf_escaped ("<span size='smaller' fgcolor='#7f7f7f'>%s</span>", desc);
+                desc_markup = g_markup_printf_escaped ("<span size='smaller'>%s</span>", desc);
 
@@ -779,2 +779,4 @@ select_vpn_type (NetConnectionEditor *editor, EggListBox *list)
                 gtk_misc_set_alignment (GTK_MISC (desc_label), 0.0, 0.5);
+                context = gtk_widget_get_style_context (desc_label);
+                gtk_style_context_add_class (context, "dim-label");
                 gtk_box_pack_start (GTK_BOX (row), desc_label, FALSE, TRUE, 0);

Fine by me with the fix squashed in.