After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674484 - nm-remote-settings doesn't disconnect signals from connections
nm-remote-settings doesn't disconnect signals from connections
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
Dan Williams
Depends on:
Blocks:
 
 
Reported: 2012-04-20 17:25 UTC by Dan Williams
Modified: 2012-04-23 18:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Williams 2012-04-20 17:25:49 UTC
Thus if a client holds references to the connection at the time the NMRemoteSettings object is freed, we might call back into the freed NMRemoteSettings when updates to that connection happens.

A bit tricky to do, since the connections move back and forth between priv->pending and priv->connections, but we always want the signal handlers connected.  One way to do this would be to create wrapper functions that handle adding the connection to the respective hash table and also connect the signals.  Then change both priv->pending and priv->connections hash table value free function to disconnect those signals by object+function+data instead of signal id.

See https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/949743
Comment 1 Dan Williams 2012-04-23 18:43:39 UTC
494f0a2e2047ca42adc73ecd6080068ce1fc9687