GNOME Bugzilla – Bug 674392
Gnome Contacts does not show contact information which Empathy used to
Last modified: 2012-05-10 11:56:30 UTC
Previously, right-clicking a contact in your contact list and picking Information would show some information about a contact. (For instance, I could see Jonny's birthday.) Similarly, right-clicking a contact in the sidebar for an IRC channel would show me /whois information, such as their real name and what other channels they are on. Now, Gnome Contacts pops up in both cases. (The first time I did this, I got a “what address book do you want to use?” window, which was a bit surprising. Once I chose to use a local address book, I seem to have three contacts: Cosimo Alfarano, Thomas Thurman, and my own SIP phone number. I don't know why I only have these three. This is someone else's bug.) Right-clicking Jonny and picking Information pops up Gnome Contacts with a card for Jonny, which shows me just his avatar, name and JID, and then shows me his avatar again and asks “Do these details belong to Jonny Lamb?”. (Screenshot to follow.) Right-clicking “jonnylamb” in the sidebar of an IRC channel pops up Gnome Contacts with a dialog box saying: ================== Contact not found =========================== No contact with id 2dee829b5529d3a70d3714ba6b09083e5d04bd5a found [ Close ] (Screenshot also to follow.) I get the same result in an XMPP MUC.
Created attachment 212357 [details] Right-clicking Jonny on my Contact List and picking Information shows this.
Created attachment 212358 [details] Right-clicking jonnylamb in a chat room and picking Information shows me this.
I should be honest: I am using Empathy 3.3.90.2 from Debian experimental, not 3.4.0.
The IRC/muc case is bug #671884 which has been fixed in 3.3.92 So this bug is "gnome-contacts should display all the contact information that Empathy's dialog use to". The missing information is basically contact info from Telepathy right?
(In reply to comment #4) > The IRC/muc case is bug #671884 which has been fixed in 3.3.92 > > So this bug is "gnome-contacts should display all the contact information that > Empathy's dialog use to". > > The missing information is basically contact info from Telepathy right? Yep, I guess so. It would also be nice if it didn't ask “Do these details belong to Jonny Lamb?”—I really don't understand that bar. Also, the “Add to My Contacts” button seems strange to me. He's already a contact. I just clicked on him in my Contact List…
the "Do these detaisl" question is the UI suggesting you to link contacts together. If that wasn't clear to you and/or if you think gnome-contacts could do a better job on this regard I suggest you to open another bug about it. The 'Add to my contacts' button has been added because now gnome-contacts only display contacts which are in your address book (so not the TP ones if they are not linked with an EDS persona). Hitting this button will add the contact to your EDS abook. I agree that sucks but I'm not the one to convinced as I disagree with the "only local contacts" change since it has been done.
Okay. So retitling. Empathy used to show the following bits of information: http://git.gnome.org/browse/empathy/tree/libempathy-gtk/empathy-contactinfo-utils.c?id=fed480fa086cba30816a5345499ceeb00ddd6d6c#n103 I guess the IRC-related stuff is not applicable in Gnome Contacts, but grabbing phone numbers, email addresses, websites and birthdays seems worthwhile.
Are these available via folks? I think we show all the data that it gives use for a persona. Maybe this is a folks-telepathy issue?
Folks does support getting ContactInfo from Telepathy but it misses API to let user (Contacts) request them: bug #675131
Created attachment 213097 [details] [review] Add Contact.fetch_contact_info()
Created attachment 213098 [details] [review] fetch contact info of selected contact This ensures we'll display as much information as possible about the contact.
Here is an easy fix allowing us to fix this issue without blocking on having proper support for this in Folks.
If we don't want to indicate info are being fetched, then +1. Otherwise, fetch_contact_info() should be made async and yield tp.contact.request_contact_info_async().
Can someone explain what information you want adding to the contact pane, please?
It doesn't really add any information, it just asks Telepathy to fetch as many information as possible: phone numbers, websites, birthday, etc. All these info are already supported by Contacts and displayed with EDS contact but were not with Telepathy contacts because of this bug.
Created attachment 213108 [details] [review] fetch contact info of selected contact This ensures we'll display as much information as possible about the contact.
Attachment 213097 [details] pushed as 5f0a9b2 - Add Contact.fetch_contact_info() Attachment 213108 [details] pushed as 951cd42 - fetch contact info of selected contact