After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674361 - Top toolbar in display shouldn't prevent win7 drag window top to maximize
Top toolbar in display shouldn't prevent win7 drag window top to maximize
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-19 02:46 UTC by Marc-Andre Lureau
Modified: 2016-03-31 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix dragging window in win7 shouldn't bring topbar (1.71 KB, patch)
2012-04-19 02:52 UTC, Marc-Andre Lureau 		committed Details | Review

Description Marc-Andre Lureau 2012-04-19 02:46:41 UTC 
Win7 (and perhaps Vista), have that window management ui that allows to maximize a window by dragging it to the top of the screen and releasing (when there is a blue overlay over the desktop). The window will then be maximzed.

Currently, with Boxes, this is very hard to work with, Since the toolbar will be bring up when reaching the top, and will catch the release event. Since it's along the whole width of the screen there is no way to avoid the toolbar and use that feature.

I think a reasonable solution would be to not bring the topbar when the button has been pressed (another solution could be to send the release event to the guest if it received the press event before the toolbar, but this is confusing imho)
Comment 1 Marc-Andre Lureau 2012-04-19 02:52:47 UTC 
Created attachment 212328 [details] [review]
Fix dragging window in win7 shouldn't bring topbar

Win7 (and perhaps Vista), have that window management ui that allows to
maximize a window by dragging it to the top of the screen and releasing (when
there is a blue overlay over the desktop). The window will then be maximzed.

Currently, with Boxes, this is very hard to work with, Since the toolbar will
be bring up when reaching the top, and will catch the release event. Since it's
along the whole width of the screen there is no way to avoid the toolbar and
use that feature.

I think a reasonable solution would be to not bring the topbar when the button
has been pressed (another solution could be to send the release event to the
guest if it received the press event before the toolbar, but this is confusing
imho)
Comment 2 Christophe Fergeau 2012-04-19 09:02:29 UTC 
Getting the overview in f17 by moving the mouse to the top left corner has similar issues if you move your mouse really fast and trigger the toolbar before the overview mode is triggered.
Comment 3 Zeeshan Ali 2012-04-19 13:16:10 UTC 
Review of attachment 212328 [details] [review]:

I don't have a win7 VM atm to test this but it looks good so if you have tested it, ACK!
Comment 4 Marc-Andre Lureau 2012-04-19 14:36:14 UTC 
Attachment 212328 [details] pushed as 51c0ca8 - Fix dragging window in win7 shouldn't bring topbar
Comment 5 Christophe Fergeau 2012-05-19 17:03:34 UTC 
This seems to cause bug #676222