After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674331 - iso list should watch for new/deleted ISOs
iso list should watch for new/deleted ISOs
Status: RESOLVED OBSOLETE
Product: gnome-boxes
Classification: Applications
Component: wizard
3.9
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 696727
 
 
Reported: 2012-04-18 13:22 UTC by Christophe Fergeau
Modified: 2018-01-11 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christophe Fergeau 2012-04-18 13:22:34 UTC
If a new iso is indexed by tracker while the list is displayed, it will not automatically appear.
Comment 1 Zeeshan Ali 2012-04-18 13:38:45 UTC
(In reply to comment #0)
> If a new iso is indexed by tracker while the list is displayed, it will not
> automatically appear.

It will but currently limitation is that only if you are not in the wizard's 'source' page. The "rationale" can be found the commit log:

commit: 02538bd 02538bd54c89f7302bb7d762d0cb5eed3e293996
Author: Zeeshan Ali (Khattak) <zeeshanak@gnome.org>
Date:   Fri Feb 10 03:08:15 2012 +0200

    wizard: Present bootable ISO files on 'Source' page
    
    Since for each addition/deletion Tracker, you get an integer ID from
    Tracker against which you use a Sparql query to check what Tracker is
    talking about, the code to handle the these signals will be inefficient
    and unnecessarily complicated. So instead of keeping a list of medias (HW
    and ISO images), we now:
    
    1. Asynchronously fetch list of medias on startup and create the widgets
    for them in the wizard.
    
    2. When the 'Source' page of wizard is activated/shown, we refetch the
    list (again asynchronously) and add/remove widgets accordingly.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=666373

But yes, we need to make this perfect.
Comment 2 Baptiste Mille-Mathias 2013-04-20 06:58:32 UTC
I guess this is still relevant, so upgrading version to latest stable.
Comment 3 Zeeshan Ali 2013-04-20 15:31:11 UTC
(In reply to comment #2)
> I guess this is still relevant, so upgrading version to latest stable.

This is not really critical or major bug so I'll not want to fix this in stable cycle.

We've been mostly keep tracking of target versions though 'feature tracker for X' metabugs. I thought I set deps for all the Boxes bugs but I guess i missed some.
Comment 4 Debarshi Ray 2015-09-02 17:24:17 UTC
(In reply to Zeeshan Ali (Khattak) from comment #1)
>     Since for each addition/deletion Tracker, you get an integer ID from
>     Tracker against which you use a Sparql query to check what Tracker is
>     talking about, the code to handle the these signals will be inefficient
>     and unnecessarily complicated. So instead of keeping a list of medias (HW
>     and ISO images), we now:

Not sure about inefficient, but if you are worried about complexity, here are some examples:
JS: https://git.gnome.org/browse/gnome-documents/tree/src/changeMonitor.js
C: https://git.gnome.org/browse/gnome-photos/tree/src/photos-tracker-change-monitor.c
Comment 5 Zeeshan Ali 2015-09-02 17:36:35 UTC
(In reply to Debarshi Ray from comment #4)
> (In reply to Zeeshan Ali (Khattak) from comment #1)
> >     Since for each addition/deletion Tracker, you get an integer ID from
> >     Tracker against which you use a Sparql query to check what Tracker is
> >     talking about, the code to handle the these signals will be inefficient
> >     and unnecessarily complicated. So instead of keeping a list of medias (HW
> >     and ISO images), we now:
> 
> Not sure about inefficient, but if you are worried about complexity, here
> are some examples:
> JS: https://git.gnome.org/browse/gnome-documents/tree/src/changeMonitor.js
> C:
> https://git.gnome.org/browse/gnome-photos/tree/src/photos-tracker-change-
> monitor.c

Thanks for pointing out examples I can follow but sad that API remains complicated.
Comment 6 Debarshi Ray 2017-04-10 18:50:46 UTC
(In reply to Zeeshan Ali (Khattak) from comment #5)
> (In reply to Debarshi Ray from comment #4)
> > Not sure about inefficient, but if you are worried about complexity, here
> > are some examples:
> > JS: https://git.gnome.org/browse/gnome-documents/tree/src/changeMonitor.js
> > C:
> > https://git.gnome.org/browse/gnome-photos/tree/src/photos-tracker-change-
> > monitor.c
> 
> Thanks for pointing out examples I can follow but sad that API remains
> complicated.

Not anymore. :)

Since tracker-1.11.0 (bug 773028), there is such a thing called TrackerNotifier that is meant to simplify GraphUpdated handling. See:
https://developer.gnome.org/libtracker-sparql/unstable/TrackerNotifier.html
Comment 7 Zeeshan Ali 2017-04-11 09:31:55 UTC
(In reply to Debarshi Ray from comment #6)
> (In reply to Zeeshan Ali (Khattak) from comment #5)
> > (In reply to Debarshi Ray from comment #4)
> > > Not sure about inefficient, but if you are worried about complexity, here
> > > are some examples:
> > > JS: https://git.gnome.org/browse/gnome-documents/tree/src/changeMonitor.js
> > > C:
> > > https://git.gnome.org/browse/gnome-photos/tree/src/photos-tracker-change-
> > > monitor.c
> > 
> > Thanks for pointing out examples I can follow but sad that API remains
> > complicated.
> 
> Not anymore. :)
> 
> Since tracker-1.11.0 (bug 773028), there is such a thing called
> TrackerNotifier that is meant to simplify GraphUpdated handling. See:
> https://developer.gnome.org/libtracker-sparql/unstable/TrackerNotifier.html

Awesome \o/
Comment 8 Felipe Borges 2017-04-18 09:25:15 UTC
That's great, I'm looking forward to land this feature in Boxes.

Currently though we are blocked by https://mail.gnome.org/archives/tracker-list/2017-April/msg00026.html

You can check that the Notifier bits are not present in tracker's vapi.
Comment 9 GNOME Infrastructure Team 2018-01-11 09:52:47 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-boxes/issues/5.