GNOME Bugzilla – Bug 674328
Cannot differentiate similar ISOs in list of ISOs
Last modified: 2016-03-31 14:02:27 UTC
Just one example, if I have several fedora 17 isos (for alpha, beta, ...) , they will all appear as "Fedora 17" in the iso list, which is not enough to pick the one to use. Similarly, if there are different ISOs in different locations (maybe one on the local HD, and one on slower storage), there is no way either to know which is which
(In reply to comment #0) > Just one example, if I have several fedora 17 isos (for alpha, beta, ...) , > they will all appear as "Fedora 17" in the iso list, which is not enough to > pick the one to use. Similarly, if there are different ISOs in different > locations (maybe one on the local HD, and one on slower storage), there is no > way either to know which is which One thing that is already on my todo is to add 'live' info. If they are different medias, we should make the difference visible somehow but if they are the same, I don't think user needs to know the location. IMHO we should just only show medias that are different (exception for unknown medias of course).
Created attachment 212744 [details] [review] Better naming for new VM boxes * Name VM based only on media label. * Resolve name conflict by appending ' 2' rather than '-1'.
Created attachment 212745 [details] [review] Mark live media as such in its label This would also imply having this suffix in VM names.
Review of attachment 212745 [details] [review]: ::: src/installer-media.vala @@ +28,3 @@ + + if (media.live) + this.label += " (Live)"; This string should be translatable
Created attachment 212775 [details] [review] Mark live media as such in its label This would also imply having this suffix in VM names.
Review of attachment 212775 [details] [review]: I think it would be more flexible for translation to have a format string like _("%s%s").printf(name, live ? _(" (live)") : _(""))
or perhaps more simply if (live) name = _("%s (live)").printf(name)
(In reply to comment #7) > or perhaps more simply if (live) name = _("%s (live)").printf(name) This is the way to go - breaking strings breaks translations. While you are at it, please add a translator comment that explains what %s will be substituted with.
Created attachment 213668 [details] [review] Mark live media as such in its label This would also imply having this suffix in VM names.
Review of attachment 213668 [details] [review]: ack
Created attachment 213670 [details] [review] Better naming for new VM boxes * Remove redundant check for availability of OS info. This is already taken care of elsewhere when label is selected. * Resolve name conflict by appending ' 2' rather than '-1'.
Review of attachment 213670 [details] [review]: ack
Attachment 213668 [details] pushed as 21a0012 - Mark live media as such in its label Attachment 213670 [details] pushed as 3e7fd98 - Better naming for new VM boxes