After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674266 - ges-launch uses POSIX regex
ges-launch uses POSIX regex
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Windows
: Normal blocker
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-17 15:22 UTC by LRN
Modified: 2012-05-01 18:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use glib regex (1.26 KB, patch)
2012-04-17 15:22 UTC, LRN 		none Details | Review
Use glib regex (1.26 KB, patch)
2012-04-18 02:50 UTC, LRN 		committed Details | Review

Description LRN 2012-04-17 15:22:01 UTC 
POSIX regex is not readily available on non-POSIX platforms (such as W32), and gst/ges already depends on GLib, so there is no reason to not to use GLib regex.
Comment 1 LRN 2012-04-17 15:22:28 UTC 
Created attachment 212218 [details] [review]
Use glib regex
Comment 2 LRN 2012-04-18 02:50:58 UTC 
Created attachment 212249 [details] [review]
Use glib regex

Fixed the logic around g_regex_match() return value (unlike POSIX regexec(), g_regex_match() returns TRUE on success, not 0).
Comment 3 Tim-Philipp Müller 2012-05-01 18:24:10 UTC 
Thanks! Care to also make a patch for:

tests/examples/ges-ui.c:#include <regex.h>
tests/examples/thumbnails.c:#include <regex.h>

? :)


commit 59e156ea3a559e73e766046726685821e6dc5065
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Tue Apr 17 19:18:44 2012 +0400

    ges-launch: use GRegex instead of POSIX regex
    
    http://bugzilla-attachments.gnome.org/attachment.cgi?id=212249