After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674228 - Name logo files according to distro names
Name logo files according to distro names
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-16 22:13 UTC by Zeeshan Ali
Modified: 2016-03-31 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Name logo files according to distro names (6.16 KB, patch)
2012-04-16 22:13 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2012-04-16 22:13:08 UTC 
Logo fetching was broken for debian, ubuntu and opensuse after the
recent short-id renaming changes in libosinfo.
Comment 1 Zeeshan Ali 2012-04-16 22:13:10 UTC 
Created attachment 212172 [details] [review]
Name logo files according to distro names

Logo fetching was broken for debian, ubuntu and opensuse after the
recent short-id renaming changes in libosinfo. Now that libosinfo
reports 'distro', lets make use of that to make logo fetching faster
and simpler while we fix this issue.
Comment 2 Marc-Andre Lureau 2012-04-16 23:01:22 UTC 
Review of attachment 212172 [details] [review]:

what is the version of osinfo that request this change? can you update the configure.ac if needed, or at least update the comment.

ack otherwise
Comment 3 Zeeshan Ali 2012-04-17 00:15:11 UTC 
(In reply to comment #2)
> Review of attachment 212172 [details] [review]:
> 
> what is the version of osinfo that request this change? can you update the
> configure.ac if needed, or at least update the comment.

We already require that version due a previous change we used 'distro' in.

> ack otherwise
Comment 4 Zeeshan Ali 2012-04-17 00:51:43 UTC 
Attachment 212172 [details] pushed as 77cbbfb - Name logo files according to distro names