After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674222 - g-s-d's hotplug-command called with arguments containing space
g-s-d's hotplug-command called with arguments containing space
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-16 20:51 UTC by Eric Piel
Modified: 2012-04-19 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
common: Fix args generation for the custom cmd (1.93 KB, patch)
2012-04-16 21:16 UTC, Bastien Nocera 		committed Details | Review

Description Eric Piel 2012-04-16 20:51:58 UTC 
g-s-d's run_custom_command() function is supposed to call the hotplug-command with arguments like this: -t added -i 5 "USB keyboard"

However, currently the -t and -i options are sent attached with their values, like this:
"-t added" "-i 5" "USB keyboard"

It makes it inconsistent with the normal unix calling, and harder to parse.
I'll attach a patch that fixes this tomorrow.
Comment 1 Bastien Nocera 2012-04-16 21:16:49 UTC 
Created attachment 212170 [details] [review]
common: Fix args generation for the custom cmd
Comment 2 Eric Piel 2012-04-16 23:11:02 UTC 
Review of attachment 212170 [details] [review]:

It looks like the right fix to me :-)
Comment 3 Bastien Nocera 2012-04-19 15:54:04 UTC 
Attachment 212170 [details] pushed as 0068157 - common: Fix args generation for the custom cmd