After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674069 - Finds H264 in a DVD ISO
Finds H264 in a DVD ISO
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal normal
: 0.10.37
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-13 19:19 UTC by Bastien Nocera
Modified: 2012-06-12 09:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
not-h264-really-but-an-iso.bin (64.00 KB, application/octet-stream)
2012-06-08 17:15 UTC, Bastien Nocera
  Details
typefind: probe for DVD ISO files, to avoid matching H.264 (1.85 KB, patch)
2012-06-11 10:10 UTC, Vincent Penquerc'h
committed Details | Review
h264parser: do not assert on data input, just return (911 bytes, patch)
2012-06-11 10:11 UTC, Vincent Penquerc'h
committed Details | Review

Description Bastien Nocera 2012-04-13 19:19:20 UTC
Somewhat currentish GStreamer

$ gst-typefind "/run/user/hadess/gvfs/hadess em facile.local./Messages à Caractère Informatif.iso"
/run/user/hadess/gvfs/hadess em facile.local./Messages à Caractère Informatif.iso - video/x-h264, stream-format=(string)byte-stream

Let me know how many bytes you need from that.
Comment 1 Vincent Penquerc'h 2012-06-08 16:39:42 UTC
For a typefind test, 64 KB ought to be enough. If not, we can always ask for more :)
Comment 2 Bastien Nocera 2012-06-08 17:15:27 UTC
Created attachment 215976 [details]
not-h264-really-but-an-iso.bin
Comment 3 Vincent Penquerc'h 2012-06-11 10:10:04 UTC
Created attachment 216090 [details] [review]
typefind: probe for DVD ISO files, to avoid matching H.264
Comment 4 Vincent Penquerc'h 2012-06-11 10:11:58 UTC
Created attachment 216091 [details] [review]
h264parser: do not assert on data input, just return
Comment 5 Vincent Penquerc'h 2012-06-11 10:17:57 UTC
commit 3a58c9ac6110b78ffa2a3268d3e10f929792829f
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Jun 11 11:09:24 2012 +0100

    typefind: probe for DVD ISO files, to avoid matching H.264
    
    https://bugzilla.gnome.org/show_bug.cgi?id=674069
Comment 6 Tim-Philipp Müller 2012-06-12 09:45:41 UTC
Isn't there some mime/media type we can use or make up for this? Like video/dvdiso (or what does gvfs use)?

That way the app can redirect to a dvd:// URI, or we can have a little element that posts a redirect message on the bus.
Comment 7 Vincent Penquerc'h 2012-06-12 09:51:42 UTC
I don't know of any existing, so I put a comment about it that we may need to typefind some more to find a more useful type. This is totally independent of whatever gvfs does though, doesn't it, as we're using internal types ?
Comment 8 Bastien Nocera 2012-06-12 09:55:59 UTC
(In reply to comment #6)
> Isn't there some mime/media type we can use or make up for this? Like
> video/dvdiso (or what does gvfs use)?

shared-mime-info uses application/x-cd-image for ISO images, x-content/video-dvd if you're certain it's a DVD image, and not something else.

> That way the app can redirect to a dvd:// URI, or we can have a little element
> that posts a redirect message on the bus.

The application should probably have handled it before passing it to GStreamer I would think.