After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674066 - Changing Gimp to LCMS2-2.3
Changing Gimp to LCMS2-2.3
Status: RESOLVED DUPLICATE of bug 675558
Product: GIMP
Classification: Other
Component: General
2.8.0-RC1
Other Windows
: Normal enhancement
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2012-04-13 17:48 UTC by Hartmut Kuhse
Modified: 2012-05-06 09:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
color-selector-cmyk-lcms.c.patch (2.26 KB, patch)
2012-04-13 17:48 UTC, Hartmut Kuhse 		none Details | Review
configure.ac.patch (1008 bytes, patch)
2012-04-13 17:49 UTC, Hartmut Kuhse 		none Details | Review
display-filter-lcms.c.patch (4.00 KB, patch)
2012-04-13 17:50 UTC, Hartmut Kuhse 		none Details | Review
display-filter-proof.c.patch (2.32 KB, patch)
2012-04-13 17:50 UTC, Hartmut Kuhse 		none Details | Review
jpeg-load.c.patch (1.60 KB, patch)
2012-04-13 17:51 UTC, Hartmut Kuhse 		none Details | Review
lcms.c.patch (3.80 KB, patch)
2012-04-13 17:51 UTC, Hartmut Kuhse 		none Details | Review
Changes from lcms1 to lcms2-2.3 (34.57 KB, patch)
2012-05-01 18:12 UTC, Hartmut Kuhse 		none Details | Review

Description Hartmut Kuhse 2012-04-13 17:48:34 UTC 
Created attachment 212007 [details] [review]
color-selector-cmyk-lcms.c.patch

I programmed some changes, concerning lcms. I tried to change from lcms 1.19 to lcms 2.3. The changes compiles against lcms2-2.3, so further enhancements can be useful for gimp? 
Maybe one of the developers can look over it?
I'm not familiar with C (coming from 'Java fields') and not familiar with diff.
Comment 1 Hartmut Kuhse 2012-04-13 17:49:00 UTC 
Created attachment 212008 [details] [review]
configure.ac.patch
Comment 2 Hartmut Kuhse 2012-04-13 17:50:34 UTC 
Created attachment 212009 [details] [review]
display-filter-lcms.c.patch
Comment 3 Hartmut Kuhse 2012-04-13 17:50:59 UTC 
Created attachment 212010 [details] [review]
display-filter-proof.c.patch
Comment 4 Hartmut Kuhse 2012-04-13 17:51:22 UTC 
Created attachment 212013 [details] [review]
jpeg-load.c.patch
Comment 5 Hartmut Kuhse 2012-04-13 17:51:58 UTC 
Created attachment 212014 [details] [review]
lcms.c.patch
Comment 6 André Klapper 2012-05-01 12:28:08 UTC 
Comment on attachment 212007 [details] [review]
color-selector-cmyk-lcms.c.patch

[Fixing wrong mime type and set "patch" flag so it can be queried for.]

Patch would need cleaning up to remove the lines commented with //.
Comment 7 André Klapper 2012-05-01 12:30:46 UTC 
Comment on attachment 212009 [details] [review]
display-filter-lcms.c.patch

Coding style: Surrounding code has spaces between function name and opening brakets for parameters, your style does not apply to that...
Comment 8 Hartmut Kuhse 2012-05-01 18:12:02 UTC 
Created attachment 213226 [details] [review]
Changes from lcms1 to lcms2-2.3

Yes, you are right. As I said, I come from java fields.
I changed source and made a new patch-file. I hope, it fits the conventions now.
Comment 9 Hartmut Kuhse 2012-05-06 09:56:24 UTC 

*** This bug has been marked as a duplicate of bug 675558 ***