After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673973 - Fix signature mismatch with GLib.TraverseFunc
Fix signature mismatch with GLib.TraverseFunc
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-12 09:05 UTC by Stef Walter
Modified: 2012-04-13 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix signature mismatch with GLib.TraverseFunc (803 bytes, patch)
2012-04-12 09:05 UTC, Stef Walter 		accepted-commit_now Details | Review

Description Stef Walter 2012-04-12 09:05:45 UTC 
Causes build problems in jhbuild

make[2]: Entering directory `/data/src/jhbuild/dconf/bin'
  VALAC  dconf_vala.stamp
dconf-dump.vala:90.16-90.23: error: Argument 1: Cannot convert from `DConfLoadState.add' to `GLib.TraverseFunc'
        tree.foreach (list.add);
                      ^^^^^^^^
Compilation failed: 1 error(s), 0 warning(s)
Comment 1 Stef Walter 2012-04-12 09:05:46 UTC 
Created attachment 211910 [details] [review]
Fix signature mismatch with GLib.TraverseFunc

 * Using vala 0.18
Comment 2 Allison Karlitskaya (desrt) 2012-04-12 17:35:24 UTC 
Review of attachment 211910 [details] [review]:

I love when we need to make changes to git dconf to remain compatible with git vala and doing so breaks our compatibility with every released tarball of vala.

Please apply to master only.  I guess this means that I'll have to wait for a vala tarball before I can do a release...
Comment 3 Stef Walter 2012-04-12 18:48:59 UTC 
(In reply to comment #2)
> I love when we need to make changes to git dconf to remain compatible with git
> vala and doing so breaks our compatibility with every released tarball of vala.

Nasty.

> Please apply to master only. 

Done.
Comment 4 Allison Karlitskaya (desrt) 2012-04-13 13:15:00 UTC 
(In reply to comment #3)
> Nasty.

I talked to Jürg yesterday and he says that Vala is going to try harder to follow the GNOME release cycle when it comes to tarballs.  This should solve the problem.