After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673963 - gtkmm's gdk target list should be non-automagic
gtkmm's gdk target list should be non-automagic
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: build
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2012-04-12 03:52 UTC by Alexandre Rostovtsev
Modified: 2012-04-17 08:42 UTC
See Also:
GNOME target: ---
GNOME version: 3.3/3.4

Attachments
proposed patch (1.29 KB, patch)
2012-04-12 03:55 UTC, Alexandre Rostovtsev 		none Details | Review
proposed patch, v2 (2.03 KB, patch)
2012-04-16 09:15 UTC, Alexandre Rostovtsev 		none Details | Review

Description Alexandre Rostovtsev 2012-04-12 03:52:11 UTC 
Currently, gtkmm-3.4.0's gdk target list is automagic, i.e. it is read at build time from gtk's pkgconfig file. This makes it inconvenient, for example, to build a wayland-only gtkmm on a machine that has gdk with both x11 and wayland backends installed.

Although automagically detecting the list of backends should certainly be the default behavior, it should be possible to override it via a configure option.
Comment 1 Alexandre Rostovtsev 2012-04-12 03:55:07 UTC 
Created attachment 211897 [details] [review]
proposed patch
Comment 2 Murray Cumming 2012-04-12 08:32:37 UTC 
Is this patch like the configure options in GTK+ itself?
Comment 3 Alexandre Rostovtsev 2012-04-12 08:51:55 UTC 
(In reply to comment #2)
> Is this patch like the configure options in GTK+ itself?

Basically, yes. Gtk+ implements the same idea as separate configure options: --enable-x11-backend, --enable-win32-backend, --enable-quartz-backend, --enable-broadway-backend, and --enable-wayland-backend. Given gtkmm's existing configure.ac, a single option with a comma-delimeted list seemed simpler.
Comment 4 Murray Cumming 2012-04-12 08:53:40 UTC 
Then I would prefer to have what GTK+ has, please.
Comment 5 Alexandre Rostovtsev 2012-04-16 09:15:44 UTC 
Created attachment 212121 [details] [review]
proposed patch, v2

(In reply to comment #4)
> Then I would prefer to have what GTK+ has, please.

OK, then this patch should do it.
Comment 6 Murray Cumming 2012-04-17 08:42:30 UTC 
Thanks. I have pushed that.