After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673884 - [PATCH] Fix memory errors when limiting the servers to search for keys
[PATCH] Fix memory errors when limiting the servers to search for keys
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2012-04-11 05:05 UTC by Robert Ancell
Modified: 2012-04-12 13:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix memory errors when limiting the servers to search for keys (1.58 KB, patch)
2012-04-11 05:06 UTC, Robert Ancell 		none Details | Review

Description Robert Ancell 2012-04-11 05:05:28 UTC 
There is a few errors in the code that chooses which servers to search for keys from:
- The keys in the hash table are freed before the hash table is finished with
- The gsettings key for the server list is not freed if it is an empty list (not sure if can happen but should be handled).
- The hash table is never freed
Comment 1 Robert Ancell 2012-04-11 05:06:37 UTC 
Created attachment 211805 [details] [review]
Fix memory errors when limiting the servers to search for keys
Comment 2 Stef Walter 2012-04-12 13:19:09 UTC 
Thanks! Merged into gnome-3-4 branch. Merge into master will come later.