After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673824 - Introduce a "ButtonBinding" system
Introduce a "ButtonBinding" system
Status: RESOLVED OBSOLETE
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-10 09:21 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-07-19 20:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keybindings: Use G_DEFINE_BOXED_TYPE (1.24 KB, patch)
2012-04-10 09:21 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
Introduce a ButtonBinding system (54.57 KB, patch)
2012-04-10 09:21 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
display: Port some of the special ops over to ButtonBindings (12.48 KB, patch)
2012-04-10 09:21 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
frames: Remove frame button grab (2.12 KB, patch)
2012-04-10 09:21 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
display: Remove grab_window_buttons (5.17 KB, patch)
2012-04-10 09:21 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
display: Move grab_focus_button into keybindings.c (9.29 KB, patch)
2012-04-10 09:21 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
display: Remove now unused meta_change_button_grab (2.76 KB, patch)
2012-04-10 09:21 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
keybindings: Remove unused keybindings_switch_window (1.95 KB, patch)
2012-07-13 04:15 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
Introduce a ButtonBinding system (54.38 KB, patch)
2012-07-13 04:15 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
display: Port some of the special ops over to ButtonBindings (12.50 KB, patch)
2012-07-13 04:15 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
frames: Remove frame button grab (2.12 KB, patch)
2012-07-13 04:15 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
display: Remove grab_window_buttons (5.17 KB, patch)
2012-07-13 04:15 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
display: Move grab_focus_button into keybindings.c (9.29 KB, patch)
2012-07-13 04:15 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
display: Remove now unused meta_change_button_grab (2.76 KB, patch)
2012-07-13 04:15 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-04-10 09:21:34 UTC
These patches are very WIP. A number of extension authors wanted
the ability to do interesting things on button presses, or scroll
events. This might be a little overengineered, especially hooking
this up to GSettings, but, welp, sorry.

Ideas for how it would be used:

  * Add a binding for <Alt>4 and <Alt>5, that adusts the opacity
    on a window.

  * <Super>4 and <Super>5 could change workspaces.

  * Set up right-click handler on the root window to add a menu
    to launch a terminal or something.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-04-10 09:21:37 UTC
Created attachment 211701 [details] [review]
keybindings: Use G_DEFINE_BOXED_TYPE
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-04-10 09:21:40 UTC
Created attachment 211702 [details] [review]
Introduce a ButtonBinding system

Similar to keybindings, buttonbindings allow you to add bindings
on buttons.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-04-10 09:21:43 UTC
Created attachment 211703 [details] [review]
display: Port some of the special ops over to ButtonBindings
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-04-10 09:21:46 UTC
Created attachment 211704 [details] [review]
frames: Remove frame button grab
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-04-10 09:21:49 UTC
Created attachment 211705 [details] [review]
display: Remove grab_window_buttons
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-04-10 09:21:52 UTC
Created attachment 211706 [details] [review]
display: Move grab_focus_button into keybindings.c
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-04-10 09:21:56 UTC
Created attachment 211707 [details] [review]
display: Remove now unused meta_change_button_grab
Comment 8 Owen Taylor 2012-04-24 22:00:12 UTC
Review of attachment 211701 [details] [review]:

sure
Comment 9 Matthias Clasen 2012-06-16 02:20:53 UTC
Do we want to expose these bindings in the control-center too ?
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-06-16 02:30:47 UTC
I don't think so, no.
Comment 11 Neil Bird 2012-06-16 06:49:48 UTC
I'm following this bug as Jasper mentioned it in answer to a question I posed in the Gnome Shell list.

Like he says in the report above, I wish to be able to do some “interesting things” with mouse clicks, esp. in relation to where they occur (e.g., over the window title bar), so as long as the API is there for extensions to hook into there's probably no need to worry about a more generic bindings GUI for the control-center, at least for now.

If a truly generic bindings *extension* is written, that could always be pulled in later (with the author's permission!).
Comment 12 Olav Vitters 2012-06-16 10:07:24 UTC
Using super+scroll wheel to move workspaces seems pretty cool! (cannot refrain from a me too, sorry :P)
Comment 13 Jasper St. Pierre (not reading bugmail) 2012-07-13 04:01:00 UTC
Comment on attachment 211701 [details] [review]
keybindings: Use G_DEFINE_BOXED_TYPE

Attachment 211701 [details] pushed as e6ed29f - keybindings: Use G_DEFINE_BOXED_TYPE
Comment 14 Jasper St. Pierre (not reading bugmail) 2012-07-13 04:15:33 UTC
Created attachment 218675 [details] [review]
keybindings: Remove unused keybindings_switch_window
Comment 15 Jasper St. Pierre (not reading bugmail) 2012-07-13 04:15:36 UTC
Created attachment 218676 [details] [review]
Introduce a ButtonBinding system

Similar to keybindings, buttonbindings allow you to add bindings
on buttons.
Comment 16 Jasper St. Pierre (not reading bugmail) 2012-07-13 04:15:38 UTC
Created attachment 218677 [details] [review]
display: Port some of the special ops over to ButtonBindings
Comment 17 Jasper St. Pierre (not reading bugmail) 2012-07-13 04:15:41 UTC
Created attachment 218678 [details] [review]
frames: Remove frame button grab
Comment 18 Jasper St. Pierre (not reading bugmail) 2012-07-13 04:15:44 UTC
Created attachment 218679 [details] [review]
display: Remove grab_window_buttons
Comment 19 Jasper St. Pierre (not reading bugmail) 2012-07-13 04:15:47 UTC
Created attachment 218680 [details] [review]
display: Move grab_focus_button into keybindings.c
Comment 20 Jasper St. Pierre (not reading bugmail) 2012-07-13 04:15:50 UTC
Created attachment 218681 [details] [review]
display: Remove now unused meta_change_button_grab
Comment 21 Jasper St. Pierre (not reading bugmail) 2013-07-19 20:01:12 UTC
I don't think I'm going to continue this.