After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673666 - e-file-helpers: catch GErrors in switch_temp_file
e-file-helpers: catch GErrors in switch_temp_file
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-06 20:09 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-04-11 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
e-file-helpers: catch GErrors in switch_temp_file (2.80 KB, patch)
2012-04-06 20:09 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-04-06 20:09:01 UTC 
Instead of the broad messages we now print.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-04-06 20:09:02 UTC 
Created attachment 211511 [details] [review]
e-file-helpers: catch GErrors in switch_temp_file

The GFile API provides useful error messages, print them when any
operation fails to aid debugging.
Comment 2 Xan Lopez 2012-04-11 11:29:51 UTC 
Review of attachment 211511 [details] [review]:

I think you need to reset the errors to NULL again if you are going to reuse them, otherwise you'll get errors if they are actually triggered. Othen than that, fine.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-04-11 15:43:57 UTC 
Attachment 211511 [details] pushed as 9757561 - e-file-helpers: catch GErrors in switch_temp_file