GNOME Bugzilla – Bug 673659
Add accessor for StartupWMClass in desktop files
Last modified: 2012-04-14 00:44:57 UTC
(picking gio for lack of a more suitable component) gnome-shell needs to read StartupWMClass for bug 673657
Created attachment 211503 [details] [review] GDesktopAppInfo: add an accessor for StartupWMClass Components using GIO to do window to application matching can use that field to retrieve potential candidates.
Review of attachment 211503 [details] [review]: Needs an entry in docs/reference/gio/gio-sections.txt. Otherwise, looks fine.
Created attachment 211517 [details] [review] GDesktopAppInfo: add an accessor for StartupWMClass Components using GIO to do window to application matching can use that field to retrieve potential candidates.
Review of attachment 211517 [details] [review]: Looks good.
Attachment 211517 [details] pushed as 3ccc4cf - GDesktopAppInfo: add an accessor for StartupWMClass
I've reverted this commit. We haven't branched yet
Hm, I didn't think adding new API like this was a break. Sorry about that.
we don't add new api in stable branches in the gtk stack - we want application authors to know that if their app builds against 2.32.10, it will run against 2.32.2 as well.
Also, the header needs to get a GLIB_AVAILABLE_IN_2_34 decoration for the new function.
Created attachment 211663 [details] [review] Add version macros for 2.34 This marks the start of the new development cycle, and opens the window for API additions.
Created attachment 211664 [details] [review] GDesktopAppInfo: add an accessor for StartupWMClass Components using GIO to do window to application matching can use that field to retrieve potential candidates. Now with version tags.
Review of attachment 211663 [details] [review]: can you add GLIB_DEPRECATED_IN_2_34 at the same time ?
Review of attachment 211664 [details] [review]: ::: gio/gdesktopappinfo.c @@ +3407,3 @@ + * @app_info. + * Returns: (transfer none): the startup WM class, or NULL if none is set + * in the desktop file. Please add an empty line before Returns:
Created attachment 212026 [details] [review] Add version macros for 2.34 This marks the start of the new development cycle, and opens the window for API additions.
Review of attachment 212026 [details] [review]: thanks, looks good now
Created attachment 212027 [details] [review] GDesktopAppInfo: add an accessor for StartupWMClass Components using GIO to do window to application matching can use that field to retrieve potential candidates.
Review of attachment 212027 [details] [review]: ::: gio/gdesktopappinfo.c @@ +3408,3 @@ + * + * Returns: (transfer none): the startup WM class, or NULL if none is set + * in the desktop file. One thing I overlooked is that NULL should be %NULL in docs. Please fix that up while committing
Attachment 212027 [details] pushed as bb7f3e0 - GDesktopAppInfo: add an accessor for StartupWMClass