After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673641 - Clean up of GstTocSetter and GstTagSetter interfaces
Clean up of GstTocSetter and GstTagSetter interfaces
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal minor
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-06 13:03 UTC by Alexander Saprykin
Modified: 2012-06-24 23:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GstTocSetter clean up (9.65 KB, patch)
2012-04-06 13:03 UTC, Alexander Saprykin 		none Details | Review
GstTagSetter clean up (5.77 KB, patch)
2012-04-06 13:03 UTC, Alexander Saprykin 		none Details | Review
GstTocSetter clean up (4.17 KB, patch)
2012-04-06 14:07 UTC, Alexander Saprykin 		committed Details | Review
GstTagSetter clean up (1.94 KB, patch)
2012-04-06 14:08 UTC, Alexander Saprykin 		committed Details | Review

Description Alexander Saprykin 2012-04-06 13:03:25 UTC 
Created attachment 211468 [details] [review]
GstTocSetter clean up

Here is a clean up of two setter interfaces, mainly static mutex removed in favor of GST_OBJECT_LOCK, and use of G_DEFINE_INTERFACE_*.
Comment 1 Alexander Saprykin 2012-04-06 13:03:53 UTC 
Created attachment 211469 [details] [review]
GstTagSetter clean up
Comment 2 Tim-Philipp Müller 2012-04-06 13:18:57 UTC 
I don't think the locking can be changed in 0.10, and I'm not sure if it's wise to change it even in master.
Comment 3 Alexander Saprykin 2012-04-06 14:07:42 UTC 
Created attachment 211475 [details] [review]
GstTocSetter clean up
Comment 4 Alexander Saprykin 2012-04-06 14:08:29 UTC 
Created attachment 211476 [details] [review]
GstTagSetter clean up
Comment 5 Tim-Philipp Müller 2012-06-24 23:31:53 UTC 
Thanks, pushed with minor changes (some things had already been changed; I removed the debug category stuff because it's completely unused)

commit 3ba43888f4fab2c45c707eee9ae05b9c5023f3bb
Author: Alexander Saprykin <xelfium@gmail.com>
Date:   Fri Apr 6 18:00:33 2012 +0400

    tagsetter: use G_DEFINE_INTERFACE_* macro
    
    https://bugzilla.gnome.org/show_bug.cgi?id=673641

commit 49eb73be7712ec244a1f21577fa372caa79514b6
Author: Alexander Saprykin <xelfium@gmail.com>
Date:   Fri Apr 6 17:59:35 2012 +0400

    tocsetter: use G_DEFINE_INTERFACE_* macro
    
    https://bugzilla.gnome.org/show_bug.cgi?id=673641