After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673602 - Print proper GStreamer plugins' names during autoconf
Print proper GStreamer plugins' names during autoconf
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.4.x
Other Linux
: Normal minor
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-05 19:27 UTC by Alexander Saprykin
Modified: 2012-04-11 12:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix (2.50 KB, patch)
2012-04-05 19:27 UTC, Alexander Saprykin 		reviewed Details | Review
Fix using shift command (2.51 KB, patch)
2012-04-10 13:30 UTC, Alexander Saprykin 		none Details | Review
Fix using shift command (2.33 KB, patch)
2012-04-10 13:35 UTC, Alexander Saprykin 		committed Details | Review

Description Alexander Saprykin 2012-04-05 19:27:56 UTC 
Created attachment 211424 [details] [review]
Patch to fix

Autoconf should print names of plugins but not the elements used to build Totem.
Comment 1 Bastien Nocera 2012-04-07 12:11:52 UTC 
Review of attachment 211424 [details] [review]:

The idea is good, but it's clumsy. Adding a new plugin check should be as easy as adding it to the list of plugins to check for.
You could use 2 arrays and the shift command for that, for example.
Comment 2 Alexander Saprykin 2012-04-10 13:30:21 UTC 
Created attachment 211734 [details] [review]
Fix using shift command

Here is another version using 'shift' and 'set' commands due to sh which doesn't support arrays.
Comment 3 Alexander Saprykin 2012-04-10 13:35:15 UTC 
Created attachment 211736 [details] [review]
Fix using shift command

Previous was dependent on the first one, sorry for that.
Comment 4 Bastien Nocera 2012-04-10 14:58:10 UTC 
Review of attachment 211736 [details] [review]:

Looks good to commit to master.
Comment 5 Bastien Nocera 2012-04-11 12:10:17 UTC 
commit ce3d32f2b1ddfafe27ab6a1f982511b8ccf85e35
Author: Alexander Saprykin <xelfium@gmail.com>
Date:   Tue Apr 10 17:32:53 2012 +0400

    Show proper names of GStreamer plugins during autoconf
    
    https://bugzilla.gnome.org/show_bug.cgi?id=673602