After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673592 - grilo: Port to grilo 0.2
grilo: Port to grilo 0.2
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-05 16:57 UTC by Bastien Nocera
Modified: 2012-04-13 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
grilo: Port to grilo 0.2 (3.93 KB, patch)
2012-04-05 16:57 UTC, Bastien Nocera 		reviewed Details | Review
grilo: Port to grilo 0.2 (3.42 KB, patch)
2012-04-07 13:46 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2012-04-05 16:57:50 UTC 
.
Comment 1 Bastien Nocera 2012-04-05 16:57:52 UTC 
Created attachment 211415 [details] [review]
grilo: Port to grilo 0.2
Comment 2 Philip Withnall 2012-04-07 13:31:22 UTC 
Review of attachment 211415 [details] [review]:

::: src/plugins/grilo/totem-grilo.c
@@ +574,3 @@
 		GList *url_keys;
 		slow_keys = grl_metadata_source_slow_keys (GRL_METADATA_SOURCE (source));
+		if (g_list_find ((GList *) slow_keys, GINT_TO_POINTER (GRL_METADATA_KEY_URL)) != NULL) {

Shouldn’t this be a separate commit?
Comment 3 Bastien Nocera 2012-04-07 13:46:24 UTC 
Created attachment 211543 [details] [review]
grilo: Port to grilo 0.2
Comment 4 Juan A. Suarez Romero 2012-04-13 11:43:49 UTC 
Review of attachment 211543 [details] [review]:

It looks good for me
Comment 5 Bastien Nocera 2012-04-13 15:04:24 UTC 
Attachment 211543 [details] pushed as 4a54e4b - grilo: Port to grilo 0.2