After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673590 - main: Remove use of totem-disc
main: Remove use of totem-disc
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 673588
Blocks: 673589
 
 
Reported: 2012-04-05 16:55 UTC by Bastien Nocera
Modified: 2012-04-13 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: Remove use of totem-disc (8.32 KB, patch)
2012-04-05 16:55 UTC, Bastien Nocera 		committed Details | Review
backend: Remove _get_mrls() helper function (4.41 KB, patch)
2012-04-11 11:36 UTC, Bastien Nocera 		committed Details | Review
backend: Remove ->media_device struct member (2.49 KB, patch)
2012-04-11 11:36 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2012-04-05 16:55:52 UTC 
.
Comment 1 Bastien Nocera 2012-04-05 16:55:54 UTC 
Created attachment 211413 [details] [review]
main: Remove use of totem-disc
Comment 2 Philip Withnall 2012-04-07 13:35:16 UTC 
Review of attachment 211413 [details] [review]:

So how do we now play DVDs?
Comment 3 Bastien Nocera 2012-04-07 13:43:43 UTC 
(In reply to comment #2)
> Review of attachment 211413 [details] [review]:
> 
> So how do we now play DVDs?

The optical media source in Grilo provides us with ready to use MRLs.
Comment 4 Bastien Nocera 2012-04-11 11:36:03 UTC 
Created attachment 211821 [details] [review]
backend: Remove _get_mrls() helper function

It's not called anymore.
Comment 5 Bastien Nocera 2012-04-11 11:36:14 UTC 
Created attachment 211822 [details] [review]
backend: Remove ->media_device struct member

As it's now unused.
Comment 6 Philip Withnall 2012-04-11 16:14:35 UTC 
Review of attachment 211821 [details] [review]:

Also needs removing from docs/reference/totem-sections.txt.
Comment 7 Bastien Nocera 2012-04-12 16:24:15 UTC 
I updated the sections.txt as well, thanks!

Attachment 211413 [details] pushed as 2acbef2 - main: Remove use of totem-disc
Attachment 211821 [details] pushed as ae0b80f - backend: Remove _get_mrls() helper function
Attachment 211822 [details] pushed as ac281cf - backend: Remove ->media_device struct member