After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673587 - Make ignore_* for schemes and mime-types HashTables
Make ignore_* for schemes and mime-types HashTables
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-05 16:51 UTC by Bastien Nocera
Modified: 2013-09-30 07:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plparse: Use hashtables in place of lists (4.20 KB, patch)
2013-09-23 06:47 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2012-04-05 16:51:00 UTC 
Rather than lists.
Comment 1 Bastien Nocera 2013-09-23 06:47:35 UTC 
Created attachment 255545 [details] [review]
plparse: Use hashtables in place of lists

This should make lookups faster.
Comment 2 Philip Withnall 2013-09-28 23:31:22 UTC 
Review of attachment 255545 [details] [review]:

::: plparse/totem-pl-parser.c
@@ +258,3 @@
 struct TotemPlParserPrivate {
+	GHashTable *ignore_schemes;
+	GHashTable *ignore_mimetypes;

Probably worth putting a comment somewhere saying these are maps from owned strings to booleans indicating membership in the ignore set.

@@ +1551,3 @@
 totem_pl_parser_scheme_is_ignored (TotemPlParser *parser, GFile *uri)
 {
+	char *scheme;

gchar?
Comment 3 Bastien Nocera 2013-09-30 07:38:08 UTC 
Attachment 255545 [details] pushed as 2bd6b00 - plparse: Use hashtables in place of lists