After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673570 - gtk-vnc must have configure option for enabling/disabling pulseaudio support
gtk-vnc must have configure option for enabling/disabling pulseaudio support
Status: RESOLVED FIXED
Product: gtk-vnc
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-vnc-maint
gtk-vnc-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-05 13:43 UTC by Maxim
Modified: 2012-04-06 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch adding --with-pulseaudio configure option (1.06 KB, patch)
2012-04-05 13:43 UTC, Maxim 		none Details | Review
a prettier (IMHO) patch (1.95 KB, patch)
2012-04-06 07:58 UTC, Alexandre Rostovtsev 		none Details | Review

Description Maxim 2012-04-05 13:43:31 UTC 
Created attachment 211381 [details] [review]
Patch adding --with-pulseaudio configure option

I'm using and developing Gentoo and here we like all optional features to be controllable by configure option. gtk-vnc can be compiled without pulseaudio support when it's not installed, but it can't be forced not to compile it when it _is_ installed, so i made a patch for you that implements --with-pulseaudio option, which will build pulseaudio support when the option is not given and pulseaudio available. Please consider merging it into sources and putting into next release.
Comment 1 Alexandre Rostovtsev 2012-04-06 07:58:24 UTC 
Created attachment 211451 [details] [review]
a prettier (IMHO) patch

Here is an (IMHO) more elegant patch for doing this, which follows the usual yes/no/check convention for --with-foo configure arguments, with check being the default, to match current configure behavior.

Also, just to be clear, the reason we want such a patch in Gentoo because we want to be able to, for example, build gtk-vnc on a machine that has pulseaudio installed and then deploy the package on a different machine that does not have pulseaudio installed, and therefore need a way to optionally disable pulseaudio auto-detection at configure time.
Comment 2 Daniel P. Berrange 2012-04-06 09:45:57 UTC 
Thanks for the patches, I have applied Alexandre's version to GIT master.