After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673539 - gkbd_keyboard_config_options_equals: fix comparison of options
gkbd_keyboard_config_options_equals: fix comparison of options
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Config
unspecified
Other All
: Normal normal
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks:
 
 
Reported: 2012-04-05 00:11 UTC by Owen Taylor
Modified: 2012-04-05 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gkbd_keyboard_config_options_equals: fix comparison of options (1.20 KB, patch)
2012-04-05 00:11 UTC, Owen Taylor 		none Details | Review

Description Owen Taylor 2012-04-05 00:11:54 UTC 
Because of a problem in some recent changes, if your config
has the same number of options as the default config, it
won't load - the comparison of the option values always
succeeds.
Comment 1 Owen Taylor 2012-04-05 00:11:55 UTC 
Created attachment 211348 [details] [review]
gkbd_keyboard_config_options_equals: fix comparison of options

Since gkbd_keyboard_config_split_items uses static storage, if
we want to call it twice and compare the results we have to
make a copy.
Comment 2 Sergey V. Udaltsov 2012-04-05 04:00:34 UTC 
Committed to master branch
Comment 3 Ray Strode [halfline] 2012-04-05 14:48:30 UTC 
argh, I just totally fail at calling that function.

Thanks for fixing.