After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673527 - Addressbook bulk methods are broken
Addressbook bulk methods are broken
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
3.4.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-04-04 19:01 UTC by Christophe Dumez
Modified: 2012-04-05 09:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (7.23 KB, patch)
2012-04-05 07:54 UTC, Christophe Dumez 		accepted-commit_now Details | Review

Description Christophe Dumez 2012-04-04 19:01:19 UTC 
It appears that the addressbook bulk methods in EBookClient were broken.
As a consequence, the following test app is no longer working:
tests/libebook/test-bulk-methods (freezes on bulk removal)

It used git bisect and identified the commit that broke it:
---
commit e144f7b5b0aba6e7903c3c98c4db792fddbf9c50
Author: Tristan Van Berkom <tristan.van.berkom@gmail.com>
Date:   Fri Jul 22 20:05:21 2011 -0400

    Make local addressbook backend store image data as URIs.
---

I haven't had time to figure out why the commit broke batch methods yet but at least we know where to look.
Comment 1 Christophe Dumez 2012-04-05 07:54:24 UTC 
Created attachment 211355 [details] [review]
Proposed patch

Now the tests/libebook/test-bulk-methods test is passing again.

The issue was caused by the maybe_delete_unused_uris() doing database requests from within a transaction but without using the transaction handle.
Comment 2 Milan Crha 2012-04-05 09:34:44 UTC 
Thanks for the patch. it looks good (and works on the test, as you said). Please commit to both master and gnome-3-4.
Comment 3 Christophe Dumez 2012-04-05 09:46:39 UTC 
Pushed to master:
c3b75f197f07d98a52559c726f70f5faf9f952f3

and gnome-3-4:
d9eb594a188804e4d15c270bbd1f8f0b8b2e2713

Thanks for reviewing.