After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673517 - impossible to confirm the use of an unprotected keyring due to grab issues
impossible to confirm the use of an unprotected keyring due to grab issues
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-04 16:25 UTC by Sebastien Bacher
Modified: 2019-02-22 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tentative patch from "Sam Spilsbury (smspillaz)" (1.27 KB, patch)
2012-04-04 16:30 UTC, Sebastien Bacher 		none Details | Review
Track disabling the grab correctly (2.04 KB, patch)
2012-04-12 14:52 UTC, Stef Walter 		none Details | Review

Description Sebastien Bacher 2012-04-04 16:25:31 UTC 
The bug has been described on https://bugs.launchpad.net/gnome-keyring/+bug/931958 and is happening with compiz > 0.9.7

Basically the "do you really want to use an unsecure password" dialog can't get keyboard or mouse focus, it can only be closed by the wm decoration

compiz's upstream wrote on the bug

"Applications shouldn't retain grabs while they have modal dialogs open. This is what seahorse is doing."

Seems the issue happens with kwin as well
Comment 1 Sebastien Bacher 2012-04-04 16:30:30 UTC 
Created attachment 211311 [details] [review]
tentative patch from "Sam Spilsbury (smspillaz)"

That's the patch compiz upstream made on https://code.launchpad.net/~smspillaz/gnome-keyring/gnome-keyring.fix_931958/+merge/100563

"track when we ungrabbed the keyboard because the window state changed so that we only re-grab it when we had initially ungrabbed it for this reason."
Comment 2 Stef Walter 2012-04-12 14:52:19 UTC 
Created attachment 211935 [details] [review]
Track disabling the grab correctly

* Only regrab when we've previously disabled the grab due to a minimize
 * Also fix regression so window can be minimized.

This patch is for gcr git master, and will be included in 3.4.1