After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673445 - dependency on GTK3 not tight enough
dependency on GTK3 not tight enough
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-03 15:54 UTC by Michael Biebl
Modified: 2012-07-03 23:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (803 bytes, patch)
2012-07-02 21:56 UTC, Alexandre Rostovtsev 		none Details | Review
proposed patch (811 bytes, patch)
2012-07-02 22:10 UTC, Alexandre Rostovtsev 		none Details | Review

Description Michael Biebl 2012-04-03 15:54:30 UTC 
gnome-power-manager uses GRessource, so it needs to bump the configure check.
Otherwise the build will fail like:

gnome_power_statistics-gpm-statistics.o: In function `gpm_stats_startup_cb':
/tmp/buildd/gnome-power-manager-3.4.0/src/gpm-statistics.c:1911: undefined reference to `gtk_builder_add_from_resource'
collect2: ld returned 1 exit status
make[4]: *** [gnome-power-statistics] Error 1
make[4]: Leaving directory `/tmp/buildd/gnome-power-manager-3.4.0/src

See also https://bugzilla.gnome.org/show_bug.cgi?id=673331
Comment 1 Alexandre Rostovtsev 2012-07-02 21:56:38 UTC 
Created attachment 217880 [details] [review]
proposed patch

Trivial patch to update the gtk+ version check in configure. OK to commit?
Comment 2 Alexandre Rostovtsev 2012-07-02 22:10:10 UTC 
Created attachment 217881 [details] [review]
proposed patch

Sorry, accidentally used the wrong email in the first version of the patch :/
Comment 3 Richard Hughes 2012-07-03 09:49:51 UTC 
Looks good to me, please commit. Thanks dude.