After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673414 - directsoundsrc: Port to 1.0
directsoundsrc: Port to 1.0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal enhancement
: 1.0.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 674242 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-04-03 09:14 UTC by Raimo Järvi
Modified: 2012-10-17 20:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
directsoundsrc: Port to 0.11 (15.85 KB, patch)
2012-04-03 09:20 UTC, Raimo Järvi 		none Details | Review
directsoundsrc: Port to 0.11 (16.42 KB, patch)
2012-05-22 11:51 UTC, Raimo Järvi 		none Details | Review
directsoundsrc: Port to 0.11 (16.40 KB, patch)
2012-05-24 09:08 UTC, Raimo Järvi 		none Details | Review
directsoundsrc: Port to 0.11 (16.29 KB, patch)
2012-07-15 21:15 UTC, Raimo Järvi 		none Details | Review
Fix compiler warning (1.24 KB, patch)
2012-10-17 19:56 UTC, Raimo Järvi 		none Details | Review

Description Raimo Järvi 2012-04-03 09:14:04 UTC 
The following patch ports directsoundsrc to 0.11.
Comment 1 Raimo Järvi 2012-04-03 09:20:13 UTC 
Created attachment 211207 [details] [review]
directsoundsrc: Port to 0.11
Comment 2 Raimo Järvi 2012-05-22 11:51:01 UTC 
Created attachment 214648 [details] [review]
directsoundsrc: Port to 0.11

Remove directsoundsrc from non ported plugins
Comment 3 Raimo Järvi 2012-05-24 09:08:50 UTC 
Created attachment 214846 [details] [review]
directsoundsrc: Port to 0.11

Fix conflict in configure.ac
Comment 4 Sebastian Dröge (slomo) 2012-07-03 11:05:50 UTC 
*** Bug 674242 has been marked as a duplicate of this bug. ***
Comment 5 Tim-Philipp Müller 2012-07-14 12:59:23 UTC 
Hrm, any chance you could rebase against master? The patch doesn't seem to apply any more unfortunately.
Comment 6 Raimo Järvi 2012-07-15 21:15:22 UTC 
Created attachment 218866 [details] [review]
directsoundsrc: Port to 0.11

Rebase against master
Comment 7 Tim-Philipp Müller 2012-10-17 13:13:11 UTC 
Thanks, pushed:

 commit a7258842ab7a68514011298c1038cca5c6e1f9a5
 Author: Raimo Järvi <raimo.jarvi@gmail.com>
 Date:   Tue Apr 3 12:09:19 2012 +0300

    directsoundsrc: port to 1.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=673414

Had to fix some merge issues, hope I didn't mess up anything. Please test if possible.
Comment 8 Raimo Järvi 2012-10-17 19:56:59 UTC 
Created attachment 226684 [details] [review]
Fix compiler warning

Thanks. It compiles, but there's a compiler warning:

cc1: warnings being treated as errors
gstdirectsoundsrc.c: In function 'gst_directsound_src_class_init':
gstdirectsoundsrc.c:170:27: error: assignment from incompatible pointer type
Comment 9 Tim-Philipp Müller 2012-10-17 20:02:25 UTC 
Thanks! (I hope we don't need to set that timestamp to NONE?)

commit 01853745a3acccc94f53137327be6c4b8565df92
Author: Raimo Järvi <raimo.jarvi@gmail.com>
Date:   Wed Oct 17 22:54:28 2012 +0300

    directsoundsrc: Fix compiler warning
    
    https://bugzilla.gnome.org/show_bug.cgi?id=673414