After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673410 - Tooltip text when editing should be translatable
Tooltip text when editing should be translatable
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-03 07:30 UTC by Laurent Contzen
Modified: 2012-04-03 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Tooltip text marked as translatable (1.15 KB, patch)
2012-04-03 07:32 UTC, Laurent Contzen 		reviewed Details | Review
Tooltip text marked as translatable (1.23 KB, patch)
2012-04-03 09:23 UTC, Laurent Contzen 		committed Details | Review

Description Laurent Contzen 2012-04-03 07:30:40 UTC 
A new tooltip text appeared when editing status (cf http://git.gnome.org/browse/empathy/commit/?id=812ecb86b9e0378f4fb0c1a59d663d067e35d136 ) but the string isn't marked as translatable as it should.
Comment 1 Laurent Contzen 2012-04-03 07:32:37 UTC 
Created attachment 211200 [details] [review]
Tooltip text marked as translatable
Comment 2 Guillaume Desmottes 2012-04-03 09:12:05 UTC 
Review of attachment 211200 [details] [review]:

::: libempathy-gtk/empathy-presence-chooser.c
@@ +384,3 @@
 		priv->editing_status = TRUE;
 
 		get_state_and_status (self, &status);

To be nice with our translators friends, it would be good to have a small comment explaining the semantic of the '%s'.
Add something like that to the line before the string:
  /* translators: %s is a status message like 'At the pub' for example */
Comment 3 Laurent Contzen 2012-04-03 09:23:38 UTC 
Created attachment 211208 [details] [review]
Tooltip text marked as translatable
Comment 4 Guillaume Desmottes 2012-04-03 09:30:12 UTC 
Merged to master, thanks!

Attachment 211208 [details] pushed as 52961fb - Tooltip text marked as translatable