After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673359 - Tooltips in chart view show the size of all folders as "13.8 EB"
Tooltips in chart view show the size of all folders as "13.8 EB"
Status: RESOLVED FIXED
Product: baobab
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Baobab Maintainers
Baobab Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-02 13:37 UTC by MT
Modified: 2012-08-20 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
chart: Fix directory size shown in tooltip (1.04 KB, patch)
2012-04-02 14:59 UTC, Stefano Facchini
committed Details | Review
Adapt to changes in the chart (1.27 KB, patch)
2012-04-03 08:51 UTC, Stefano Facchini
accepted-commit_now Details | Review

Description MT 2012-04-02 13:37:27 UTC
Hovering the mouse cursor over any folder represented in the chart view shows a tooltip with the size of the folder displayed as 13.8 EB. The sizes are correctly displayed in the table on the left.
Comment 1 Stefano Facchini 2012-04-02 14:57:27 UTC
Bisected to commit b6642cd2d4e99fe
Comment 2 Stefano Facchini 2012-04-02 14:59:59 UTC
Created attachment 211138 [details] [review]
chart: Fix directory size shown in tooltip

A typo introduced in commit b6642cd2d4e99fe.
Comment 3 Paolo Borelli 2012-04-02 15:15:40 UTC
Review of attachment 211138 [details] [review]:

oooops. please commit on all branches including vala ones
Comment 4 Stefano Facchini 2012-04-02 15:23:19 UTC
Comment on attachment 211138 [details] [review]
chart: Fix directory size shown in tooltip

the vala branch will pick it up on next rebase :)
Comment 5 Stefano Facchini 2012-04-03 08:50:09 UTC
So, after all it seems that the change in the chart was not a typo. Paolo probabily did it to make the chart already adapted to the vala version. To avoid problems when rebasing, I think that the previous patch should be reverted and replaced with the following. Sorry for the spam :)
Comment 6 Stefano Facchini 2012-04-03 08:51:03 UTC
Created attachment 211204 [details] [review]
Adapt to changes in the chart

In view of the forthcoming merge of the vala rewriting branch, this is
better fix to the bufìg than commit af46a41474a.
Comment 7 Paolo Borelli 2012-04-03 08:54:43 UTC
Review of attachment 211204 [details] [review]:

indeed I backported the updated charts widget from the vala version and didn't realize that we had this inconsistency. If you tested and there are no further side effects feel free to push
Comment 8 André Klapper 2012-08-20 15:18:47 UTC
(In reply to comment #7)
> If you tested and there are no further side effects feel free to push

Stefano: Have you tested and pushed the patch already? 
Do you have Git access?
Comment 9 Paolo Borelli 2012-08-20 15:21:02 UTC
This is not releavent anymore, the vala rewrite is now released :)