GNOME Bugzilla – Bug 673344
Please clean up license information
Last modified: 2013-01-14 19:54:10 UTC
While parts of the gnome-terminal sources are under GPL-3+, some files are under LGPL-3+ and one under LGPL-2.1+. Please consider cleaning up the license mix and putting all files under GPL-3+.
$ licensecheck . -r | grep " GPL" | sort ./src/extra-strings.c: GPL (v3 or later) ./src/profile-editor.c: GPL (v3 or later) ./src/terminal-accels.c: GPL (v3 or later) ./src/terminal-app.c: GPL (v3 or later) ./src/terminal.c: GPL (v3 or later) ./src/terminal-close-button.c: GPL (v3 or later) ./src/terminal-close-button.h: GPL (v3 or later) ./src/terminal-encoding.c: GPL (v3 or later) ./src/terminal-info-bar.c: GPL (v3 or later) (with incorrect FSF address) ./src/terminal-info-bar.h: GPL (v3 or later) (with incorrect FSF address) ./src/terminal-options.c: GPL (v3 or later) ./src/terminal-options.h: GPL (v3 or later) ./src/terminal-profile.c: GPL (v3 or later) ./src/terminal-screen.c: GPL (v3 or later) ./src/terminal-search-dialog.c: GPL (v3 or later) (with incorrect FSF address) ./src/terminal-search-dialog.h: GPL (v3 or later) (with incorrect FSF address) ./src/terminal-tab-label.c: GPL (v3 or later) (with incorrect FSF address) ./src/terminal-tab-label.h: GPL (v3 or later) (with incorrect FSF address) ./src/terminal-tabs-menu.c: GPL (v3 or later) ./src/terminal-tabs-menu.h: GPL (v3 or later) ./src/terminal-util.c: GPL (v3 or later) ./src/terminal-window.c: GPL (v3 or later) $ licensecheck . -r | grep " LGPL" | sort ./src/eggdesktopfile.c: LGPL (v3 or later) (with incorrect FSF address) ./src/eggdesktopfile.h: LGPL (v3 or later) (with incorrect FSF address) ./src/eggshell.c: LGPL (v3 or later) (with incorrect FSF address) ./src/eggshell.h: LGPL (v3 or later) (with incorrect FSF address) ./src/eggsmclient.c: LGPL (v3 or later) (with incorrect FSF address) ./src/eggsmclient.h: LGPL (v3 or later) (with incorrect FSF address) ./src/eggsmclient-osx.c: LGPL (v3 or later) (with incorrect FSF address) ./src/eggsmclient-private.h: LGPL (v3 or later) (with incorrect FSF address) ./src/eggsmclient-win32.c: LGPL (v3 or later) (with incorrect FSF address) ./src/eggsmclient-xsmp.c: LGPL (v3 or later) (with incorrect FSF address) ./src/profile-editor.h: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-accels.h: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-app.h: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-debug.c: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-debug.h: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-encoding.h: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-intl.h: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-profile.h: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-screen-container.c: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-screen-container.h: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-screen.h: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-util.h: LGPL (v3 or later) (with incorrect FSF address) ./src/terminal-version.h: LGPL (v2.1 or later) (with incorrect FSF address) ./src/terminal-window.h: LGPL (v3 or later) (with incorrect FSF address)
egg* is copypasted from ligegg, so if there's anything wrong with the FSF address in them, that should be fixed upstream and in g-t. All other files that are LGPL are that by mistake, they should be GPL.
(In reply to comment #2) > egg* is copypasted from ligegg Bug report against libegg is welcome.
On the gsettings branch, everything is now licenced correctly as GPL3+. (This branch will become master for 3.6 or 3.8, depending on progress.) Someone wants to do a patch to fix all the 'incorrect FSF address' stuff on that branch?
gsettings branch is now on master. All that reamins is the 'fsf address' fixes.
I guess I could prep a patch for the incorrect FSF address. (L)GPL v3 actually no longer refers to writing to the FSF to get a copy of the (L)GPL but points to the homepage instead, i.e. instead of You should have received a copy of the GNU Lesser General Public License along with this library; see the file COPYING.LIB. If not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. it uses something along those lines You should have received a copy of the GNU General Public License along with Foobar. If not, see <http://www.gnu.org/licenses/>. [1] http://www.gnu.org/licenses/gpl-howto.html
Created attachment 232420 [details] [review] all: Cleanup license headers some more Use the most recent wording from http://www.gnu.org/licenses/gpl.html Fixes 'incorrect FSF address' warnings
Created attachment 232422 [details] [review] all: Cleanup license headers some more Use the most recent wording from http://www.gnu.org/licenses/gpl.html Fixes 'incorrect FSF address' warnings
Created attachment 232423 [details] [review] all: Cleanup license headers some more Use the most recent wording from http://www.gnu.org/licenses/gpl.html Fixes 'incorrect FSF address' warnings
- * Author: Christian Neumair <chris@gnome-de.org> Don't drop Author information, where it exists. With that fixed, please commit to master. Thanks!
Attachment 232423 [details] pushed as 8721e5a - all: Cleanup license headers some more