After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673285 - Get rid of liboil in gst*
Get rid of liboil in gst*
Product: GStreamer
Classification: Platform
Component: dont know
git master
Other All
: Normal trivial
: 1.0.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2012-04-01 08:19 UTC by LRN
Modified: 2012-09-29 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description LRN 2012-04-01 08:19:04 UTC
This is what grep tells me about non-changelog mentions of liboil in gst*:

gstreamer/docs/faq/dependencies.xml - mentions liboil as one of the mandatory dependencies

gst-plugins-base/tests/check/elements/ffmpegcolorspace.c - sets OIL_CPU_FLAGS (but doesn't use liboil)

gst-plugins-base/gst/audioconvet/gstchannelmix.c - mentions that liboil might be used to optimize inner loops

gst-plugins-base/gst/playback/gstplaysink.c - mentions liboil in some kind of error message.

win32 stuff in gst-plugins-base contains liboil .lib file references

gst-plugins-base/tests/check/elements/videotestsrc.c - sets OIL_CPU_FLAGS (but doesn't use liboil)

gst-plugins-good/gst/level/gstlevel.c - a commented-out calls to liboil

win32 stuff in gst-plugins-good contains liboil .lib file references

gst-plugins-good/tests/check/elements/videocrop.c - sets OIL_CPU_FLAGS (but doesn't use liboil)

gst-plugins-ugly/ext/a52dec/gsta52dec.c - logs "liboil" as a source of cpu flags (but uses orc to get them)

gst-plugins-ugly/gst/dvdsub/gstdvdsubdec.c - TODO: liboil-ise code, esp. use _splat() family of functions

gst-plugins-ugly/REQUIREMENTS - claims that it requires liboil >= 0.2.0

gst-plugins-bad/ext/cog/cogframe.c - liboil calls in commented-out chunks of code

gst-plugins-bad/ - claims that it requires liboil-devel

gst-plugins-bad/ext/dts/gstdtsdec.c - logs "liboil" as a source of cpu flags (but uses orc to get them)

gst-plugins-bad/ext/cog/gstlogoinsert.c  - uses oil_divide_255(x), which is just a define for ((((x)+128) + (((x)+128)>>8))>>8)

gst-plugins-bad/gst/games/gstpuzzle.c - if compiled with liboil support, calls oil_init
gst-plugins-bad/gst/games/gstvideoimage.c - if compiled with liboil support, includes liboil/liboil.h and calls oil_splat_u8(), otherwise uses a C backup implementation
gst-plugins-bad/gst/games/ - adds $(LIBOIL_LIBS) to LDFLAGS for libgstpuzzle
gst-plugins-bad/ext/directfb/ - adds $(LIBOIL_LIBS) to LIBADD for libgstfbvideosink

gst-plugins-bad/ext/wayland/ - adds $(LIBOIL_LIBS) to LIBADD for libgstwaylandsink

gst-ffmpeg/ - claims that it requires liboil-devel >= 0.3.6, and that is the only place where liboil is mentioned in gst-ffmpeg

That is, only bad/gst/games actually uses liboil.
Comment 1 David Schleef 2012-04-01 19:51:04 UTC
Oh wow.  Thanks for creating this list.
Comment 2 Tim-Philipp Müller 2012-09-29 11:41:00 UTC
I've fixed most of these up, but left some references intact, esp. the old win32 build files and the unported-since-0.8 days gst/games. Doesn't hurt or confuse anyone to leave them there.