After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673274 - ephy-download-test: correctly use fixture objects
ephy-download-test: correctly use fixture objects
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-01 02:44 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-04-02 10:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-download-test: correctly use fixture objects (1.46 KB, patch)
2012-04-01 02:45 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-04-01 02:44:58 UTC 
new_for_uri was doing some silly asserts, plus creating lots of trash
files in your user's downloads dir.

Just check for what we gotta check, no more.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-04-01 02:45:00 UTC 
Created attachment 211059 [details] [review]
ephy-download-test: correctly use fixture objects

Do not use adhoc EphyDownload objects that have no proper destination
set, or your current user's downloads directory will be filled with test
files.
Comment 2 Xan Lopez 2012-04-02 10:04:09 UTC 
Review of attachment 211059 [details] [review]:

Uh, yes.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-04-02 10:20:01 UTC 
Attachment 211059 [details] pushed as f056c1e - ephy-download-test: correctly use fixture objects