After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673185 - [0.11] [tagdemux] pull mode broken
[0.11] [tagdemux] pull mode broken
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.11.x
Other Linux
: Normal blocker
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-30 14:51 UTC by Mark Nauwelaerts
Modified: 2012-09-11 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Mark Nauwelaerts 2012-03-30 14:51:44 UTC 
[applies to 0.11 == master]

Looks like tagdemux activated in pull mode (e.g. when followed by some audio parser) never comes around to do any tag-finding (e.g. id3demux ! mpegaudioparse does not come up with tags).

Push mode is marginally different in that it fails the pipeline altogether (e.g. id3demux ! queue ! mpegaudioparse).
Comment 1 Mark Nauwelaerts 2012-04-16 15:58:11 UTC 
Also looks like typefind has some silimar difficulties (albeit in a marginally better state overall).
Comment 2 Tim-Philipp Müller 2012-09-11 19:58:14 UTC 
This was the best I could think of (without doing it in the application thread):

commit ec27f4e13ce819c843c5c66ac2ee91eade85cd50
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Tue Sep 11 20:53:16 2012 +0100

    tagdemux: also read tags if downstream activates us in pull mode right away
    
    Fix reading of tags for the case filsrc ! footagdemux ! fooparse ! ..
    where we would not read the tags because we never start our own
    streaming thread.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=673185

Typefind should just skip typefinding in that case IMHO (that's what I did for tagdemux as well now) - an element activating upstream in pull mode is probably not really expecting or needing a CAPS event from upstream.