After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673141 - Right-click on GOA account let you disable it
Right-click on GOA account let you disable it
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-30 07:10 UTC by Xavier Claessens
Modified: 2012-03-30 11:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
factor out account_can_be_enabled() (2.26 KB, patch)
2012-03-30 11:08 UTC, Guillaume Desmottes 		committed Details | Review
empathy-accounts: disable 'Enable' menu entry if not supported (990 bytes, patch)
2012-03-30 11:08 UTC, Guillaume Desmottes 		none Details | Review
empathy-accounts: disable 'Enable' menu entry if not supported (971 bytes, patch)
2012-03-30 11:13 UTC, Guillaume Desmottes 		none Details | Review
empathy-accounts: disable 'Enable' menu entry if not supported (1.84 KB, patch)
2012-03-30 11:16 UTC, Guillaume Desmottes 		committed Details | Review

Description Xavier Claessens 2012-03-30 07:10:24 UTC 
In empathy-accounts dialog, if you right click on an account in the left column, you can enable/disable the account. But that option should be removed for GOA account since we don't do it.

Also that context menu could have a "rename" item.
Comment 1 Guillaume Desmottes 2012-03-30 11:08:54 UTC 
Created attachment 210939 [details] [review]
factor out account_can_be_enabled()
Comment 2 Guillaume Desmottes 2012-03-30 11:08:57 UTC 
Created attachment 210940 [details] [review]
empathy-accounts: disable 'Enable' menu entry if not supported
Comment 3 Guillaume Desmottes 2012-03-30 11:10:01 UTC 
(In reply to comment #0)

> Also that context menu could have a "rename" item.

Bug #673159
Comment 4 Guillaume Desmottes 2012-03-30 11:13:00 UTC 
Created attachment 210941 [details] [review]
empathy-accounts: disable 'Enable' menu entry if not supported
Comment 5 Guillaume Desmottes 2012-03-30 11:16:42 UTC 
Created attachment 210943 [details] [review]
empathy-accounts: disable 'Enable' menu entry if not supported
Comment 6 Xavier Claessens 2012-03-30 11:17:19 UTC 
+1 this time :D
Comment 7 Guillaume Desmottes 2012-03-30 11:25:15 UTC 
Attachment 210939 [details] pushed as a3c14d3 - factor out account_can_be_enabled()
Attachment 210943 [details] pushed as d1576b8 - empathy-accounts: disable 'Enable' menu entry if not supported