After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673046 - Video preview is always behind the incoming video
Video preview is always behind the incoming video
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-29 08:50 UTC by Guillaume Desmottes
Modified: 2012-03-30 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
call-window: raise the overlay actor instead of individual actors (1.79 KB, patch)
2012-03-29 16:11 UTC, Cosimo Cecchi 		committed Details | Review

Description Guillaume Desmottes 2012-03-29 08:50:34 UTC 
Looks like a regression in master because it works fine with 3.4.0.
Comment 1 Guillaume Desmottes 2012-03-29 08:56:48 UTC 
The regression has been introduced by this commit.

Cosimo: any idea? If not I'll probably revert it for 3.4.1.

commit d9c6227d30e2eb6521421c01f03749e8a4c576e9
Author: Cosimo Cecchi <cosimoc@gnome.org>
Date:   Thu Mar 22 18:25:41 2012 -0400

    call-window: use a ClutterBoxLayout to separate previews/toolbar
    
    It's way easier to use a ClutterBoxLayout to ensure the preview
    rectangles and the floating toolbar don't overlap.
    This way, we can get rid of some complicated manual UI layouting code
    and just a margin to set the bottom spacing for the floating toolbar.
    Also, this makes the code not dependent on a hardcoded toolbar size
    anymore.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=672560
Comment 2 Cosimo Cecchi 2012-03-29 16:11:29 UTC 
Created attachment 210875 [details] [review]
call-window: raise the overlay actor instead of individual actors

This seems to solve the bug.
Comment 3 Guillaume Desmottes 2012-03-30 13:08:26 UTC 
Review of attachment 210875 [details] [review]:

That solved the bug for me; thanks a lot.

Please merge to master (I didn't branch yet).
Comment 4 Cosimo Cecchi 2012-03-30 15:40:30 UTC 
Attachment 210875 [details] pushed as 92f20f6 - call-window: raise the overlay actor instead of individual actors