After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672937 - treeview: filter out invisible columns in get_path_for_child()
treeview: filter out invisible columns in get_path_for_child()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-03-27 16:24 UTC by Cosimo Cecchi
Modified: 2012-03-27 16:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
treeview: filter out invisible columns in get_path_for_child() (2.23 KB, patch)
2012-03-27 16:24 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-03-27 16:24:30 UTC 
See attached patch and commit message for the rationale.
Comment 1 Cosimo Cecchi 2012-03-27 16:24:32 UTC 
Created attachment 210713 [details] [review]
treeview: filter out invisible columns in get_path_for_child()

Since we check for !list->next (and !list->prev for RTL) to set the
GTK_REGION_LAST flag, we have to filter out invisible columns before
looping; if we don't do that we might end up assigning GTK_REGION_LAST
to an invisible column.
Comment 2 Cosimo Cecchi 2012-03-27 16:39:40 UTC 
Attachment 210713 [details] pushed as 52bd5f2 - treeview: filter out invisible columns in get_path_for_child()

Pushed to git after Benjamin's review on IRC.