After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672919 - don't dist generated files
don't dist generated files
Status: RESOLVED FIXED
Product: yelp-tools
Classification: Core
Component: yelp.m4
git master
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-27 14:15 UTC by Christian Persch
Modified: 2013-11-25 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
yelp.m4: Prepare for multiple options case (1.66 KB, patch)
2013-11-24 22:22 UTC, Christian Persch
none Details | Review
yelp.m4: Add no-lc-dist option (1.82 KB, patch)
2013-11-24 22:22 UTC, Christian Persch
none Details | Review
yelp.m4: Prepare for multiple options case (1.65 KB, patch)
2013-11-24 22:23 UTC, Christian Persch
none Details | Review
yelp.m4: Add no-lc-dist option (1.81 KB, patch)
2013-11-25 14:27 UTC, Christian Persch
none Details | Review

Description Christian Persch 2012-03-27 14:15:39 UTC
Then generated $lc/*.xml (except for $lc = C) and $lc/*.stamp files are generated files and just unnecessarily bloat the tarball.
Comment 1 Frederic Peters 2012-04-16 20:52:35 UTC
Note this would break library.gnome.org, as there is no build environment in there.
Comment 2 Christian Persch 2013-11-24 22:22:26 UTC
Created attachment 261376 [details] [review]
yelp.m4: Prepare for multiple options case

Bug #672919.

Proposed patches; untested for now :-)
Comment 3 Christian Persch 2013-11-24 22:22:33 UTC
Created attachment 261377 [details] [review]
yelp.m4: Add no-lc-dist option

Add no-lc-dist option to disable disting the generated lc files. Disabled by
default for backwards compatibility.
Comment 4 Christian Persch 2013-11-24 22:23:56 UTC
Created attachment 261378 [details] [review]
yelp.m4: Prepare for multiple options case

Bug #672919.
Comment 5 Christian Persch 2013-11-25 14:27:33 UTC
Created attachment 261436 [details] [review]
yelp.m4: Add no-lc-dist option

Add no-lc-dist option to disable disting the generated lc files. Disabled by
default for backwards compatibility.
Comment 6 Shaun McCance 2013-11-25 15:36:06 UTC
Pushed to master. Thanks.
Comment 7 Frederic Peters 2013-11-25 16:10:59 UTC
I wrote:

> Note this would break library.gnome.org, as there is no build environment in there.

Now that it has been pushed :/, I have filed bug 715174 against help.gnome.org.
Comment 8 Christian Persch 2013-11-25 16:36:28 UTC
It's just an option that modules can use, and not the default. I'll introduce it in aisleriot just for testing; if the lib.g.o support doesn't arrive for 3.12, I could then switch it off again.
Comment 9 Frederic Peters 2013-11-25 16:52:57 UTC
Sure; and I will have time to work on library-web during the documentation hackfest in January, so I'm pretty sure it will be ok for 3.12.