After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672907 - Use glib resources four UI files
Use glib resources four UI files
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-27 11:31 UTC by Xan Lopez
Modified: 2012-03-27 19:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
resources.diff (11.72 KB, patch)
2012-03-27 11:33 UTC, Xan Lopez 		needs-work Details | Review

Description Xan Lopez 2012-03-27 11:31:08 UTC 
Subject pretty much says it all. Bundle our ui/xml/css files in the binary itself to speed up loading and make the binary easy to relocate in the future.
Comment 1 Xan Lopez 2012-03-27 11:33:07 UTC 
Created attachment 210687 [details] [review]
resources.diff
Comment 2 Claudio Saavedra 2012-03-27 12:04:14 UTC 
Review of attachment 210687 [details] [review]:

Otherwise, looks good as far as I can tell.

::: src/Makefile.am
@@ +8,3 @@
 
+EXTRA_DIST = \
+	epiphany.gresource.xml \

You forgot to include this file in the patch.
Comment 3 Xan Lopez 2012-03-27 19:14:04 UTC 
(In reply to comment #2)
> Review of attachment 210687 [details] [review]:
> 
> Otherwise, looks good as far as I can tell.
> 
> ::: src/Makefile.am
> @@ +8,3 @@
> 
> +EXTRA_DIST = \
> +    epiphany.gresource.xml \
> 
> You forgot to include this file in the patch.

Oops, yeah. The file is not very interesting, just a list of the files in XML format... Thanks for the review!
Comment 4 Xan Lopez 2012-03-27 19:43:14 UTC 
Pushed to master.