After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672872 - Sane default sound & video devices for unknown OSs
Sane default sound & video devices for unknown OSs
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-03-26 19:40 UTC by Zeeshan Ali
Modified: 2016-03-31 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Sane default sound & video devices for unknown OSs (2.05 KB, patch)
2012-03-26 19:40 UTC, Zeeshan Ali 		reviewed Details | Review
Sane default sound & video devices for unknown OSs (2.05 KB, patch)
2012-03-26 20:54 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2012-03-26 19:40:25 UTC 
Background from IRC:

<mclasen_> can we make boxes use qxl instead of cirrus ?
<zeenix> mclasen_: it does already
<zeenix> mclasen_: but you need drivers in the guest and expression installation does that for fedora already
<zeenix> mclasen_: teuf is working on making it work for windows as well
<mclasen_> zeenix: I am seeing the qxl driver in this f17 livecd install
<mclasen_> and still I see -vga cirrus in the qemu commandline
<zeenix> mclasen_: weird cause qemu commandline should always be qxl
<zeenix> oh
<zeenix> i might know
<zeenix> F17 isn't in the libosinfo db yet :)
Comment 1 Zeeshan Ali 2012-03-26 19:40:27 UTC 
Created attachment 210658 [details] [review]
Sane default sound & video devices for unknown OSs
Comment 2 Marc-Andre Lureau 2012-03-26 19:53:27 UTC 
Review of attachment 210658 [details] [review]:

::: src/vm-configurator.vala
@@ +201,3 @@
+        var device = get_os_device_by_prop (install_media.os, DEVICE_PROP_CLASS, "audio");
+        var model = (device != null)? get_enum_value (device.get_name (), typeof (DomainSoundModel)) :
+                                      DomainSoundModel.ICH6;

ICH6 is too recent, even XPSP3 doesn't support it. AC97 otoh is supported on all OS I have tried.
Comment 3 Zeeshan Ali 2012-03-26 20:54:15 UTC 
Created attachment 210662 [details] [review]
Sane default sound & video devices for unknown OSs

This one uses AC97.
Comment 4 Marc-Andre Lureau 2012-03-26 21:08:51 UTC 
Review of attachment 210662 [details] [review]:

ack
Comment 5 Zeeshan Ali 2012-03-26 21:30:16 UTC 
Attachment 210662 [details] pushed as f17ab83 - Sane default sound & video devices for unknown OSs