GNOME Bugzilla – Bug 672841
Link to code repository sources in module pages
Last modified: 2018-05-22 12:13:27 UTC
Could the module pages have a link to the source (git) ? It would be helpful to check more context, or just find out the right module to checkout.
Isn't there already such a link? For instance on http://l10n.gnome.org/module/release-notes/ you can see "gnome-3-4 (Browse Repository)" ("gnome-3-4 (Examiner le dépôt)" in French) that links to the git repository.
To make it more explicit, and to keep the example of the release notes, I would like a link on this page [1] pointing at [2] [1] http://l10n.gnome.org/vertimus/release-notes/gnome-3-4/help/fr [2] http://git.gnome.org/browse/release-notes/tree/help/C Currently it requires 5 or 6 clicks to reach the right page, assuming we are familiar with DL and the source tree.
(In reply to comment #0) > Could the module pages have a link to the source (git) ? > > It would be helpful to check more context, or just find out the right module to > checkout. Cluttering the translation module page (i.e. [1]) with another link I would say that it's a bit too much. You just need to click on the module name on that same page and you already have a link to its source code repository there. Moreover if the use case you have in mind is for getting more context, shouldn't that be provided not on the D-L but on the translation program you actually use? For instance gtranslator already has this functionality built in, and I'm sure that lokalize and quite a few other apps have similar functionality. A task to help "while translating" should be provided by the tools you use "while translating". If at any point D-L gains the ability to edit po files directly from the web interface (discussed in other bugs and ML before) then I would say: yes, let's provide that. But for now that D-L is "only" a statistics and workflow management tool I would rather keep the interface cleaner. [1] http://l10n.gnome.org/vertimus/evince/master/po/ca
(about the cluttering of the page, you are joking, right?)
Hi Gil, A tool has no idea from which source where a .po file comes from. The module page is where the .po file is taken. This is the exact place where it should say where the corresponding source is. Ideally the file could embed where it comes from (git repo + ref), but this is really useful only if another tool can read this information. Try this yourself: 1. go to a random module page 2. now show the corresponding source by doing so, count the number of clicks and keys pressed count also the information that comes from your own knowledge Now imagine you are a newbie, or you are very busy, or you just have an old brain like me. It could be straight forward and click-simple, but it is a pain.
(In reply to comment #5) > A tool has no idea from which source where a .po file comes from. The idea is to download the latest po from Damned lies and put it in your local clone of the git repository of the project, at the right spot. Then your translation tool will be able to open the right file to give context because the po file has the relative path. In addition to the tools cited as working by Gil, there's also poedit (right click on the string gives an option to open the file) and vim + po.vim (gf has been remapped to split open the file). > The module page is where the .po file is taken. This is the exact place where > it should say where the corresponding source is. Damned lies is a statistics and workflow handling tool.
(In reply to comment #4) > (about the cluttering of the page, you are joking, right?) No I was completely serious... see the attached image, where do you want to put the source code link? On line below the three links for downloading a POT/PO/PO-reduced? On the other side below the sets that the module is in? Yes, for me that's cluttered and just as Alexandre, and previously myself, says, D-L is a statistics and workflow tool, not a translation one. A redesign of that page with accordion-like switches to expand more info could be a solution, but I would not like to push a patch to add only more info there without really thinking about it.
Created attachment 222381 [details] Current look of a module page
Gil, you're right, the top of the page is cluttered. But adding one word (this issue) is not cluttering the page much more (that's the joke part; kindly). With good will, the page could be easily reorganised, so that's not an issue here. I feel a strong opposition here, but I don't see the rational. Especially, you don't pass my test (comment 5), why? You would realise what the issue is about
Created attachment 222449 [details] a module page with less clutter and more information
Created attachment 222450 [details] a module page with even less clutter just to show how the clutter is not an issue
Created attachment 242574 [details] An implementation of Luc's layout I was looking into the layout disposition that Luc provided and I came up with this (patch follows)
Created attachment 242575 [details] [review] Patch to improve po statistics layout
Review of attachment 242575 [details] [review]: quick review Note 1: this patch has nothing to do with this bug report (#672841) Note 2: but I am happy to see these changes, so let's help. See below inline suggestions. In addition, I would suggest, - move the "State:" line at the bottom of the statistics because the statistics are about the stored files while the will change https://git.gnome.org/browse/damned-lies/tree/templates/vertimus/vertimus_detail.html#n50 - move the module description [2] just after the title [2] https://git.gnome.org/browse/damned-lies/tree/templates/vertimus/vertimus_detail.html#n57 ::: templates/vertimus/vertimus_detail.html @@ +72,1 @@ {{ pot_stats.pot_text }} move the {{ pot_stats.pot_text }} inside the <a> @@ +84,3 @@ + <img src="{{ STATIC_URL }}img/download.png" + alt="{% trans "Download PO file" %}" /> + {% trans "PO file statistics:" %} s/PO file statistics:/PO file/ we don't download statistics @@ +132,3 @@ + <img src="{{ STATIC_URL }}img/download.png" + alt="{% trans "Download PO file (reduced)" %}" /> + {% trans "PO file statistics (reduced):" %} s/PO file statistics (reduced):/PO file (reduced)/ we don't download statistics
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/damned-lies/issues/33.