After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672838 - Add soup_cookie_jar_is_persistent()
Add soup_cookie_jar_is_persistent()
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: API
2.37.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2012-03-26 09:54 UTC by Carlos Garcia Campos
Modified: 2012-04-18 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add SoupCookieJar:is-persistent property (5.38 KB, patch)
2012-03-26 09:54 UTC, Carlos Garcia Campos 		needs-work Details | Review
Updated patch using vmethod (6.08 KB, patch)
2012-03-26 15:48 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-03-26 09:54:03 UTC 
Created attachment 210607 [details] [review]
Add SoupCookieJar:is-persistent property

This will be used by WebKit to know whether cookies are persistent or not.
Comment 1 Dan Winship 2012-03-26 12:54:13 UTC 
Comment on attachment 210607 [details] [review]
Add SoupCookieJar:is-persistent property

This would allow the app to create a cookie jar with is-persistent set to the wrong value (by calling g_object_new() directly rather than one of the soup_cookie_jar_*new() methods).

You should do it as a virtual method instead.
Comment 2 Carlos Garcia Campos 2012-03-26 13:14:11 UTC 
You are right, my initial idea was to add a virtual method indeed, but then I thought I could avoid using a class padding by adding a new property. I'll rework the patch.
Comment 3 Carlos Garcia Campos 2012-03-26 15:48:12 UTC 
Created attachment 210637 [details] [review]
Updated patch using vmethod
Comment 4 Dan Winship 2012-03-30 13:41:32 UTC 
Comment on attachment 210637 [details] [review]
Updated patch using vmethod

looks good. I plan to branch fairly soon. I'll land this when I do.
Comment 5 Dan Winship 2012-04-18 15:01:49 UTC 
committed to master